Log stringified exceptions in debug output #5164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception (e.g. Zotero.Exception.UnloadedDataException) is thrown without the debugger enabled (meaning, by most users), it is logged as a non-descriptive [JavaScript Error: "uncaught exception: Object"]. This stringifies the exception object and puts the string into the message, so that the actual error and the stacktrace are not lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception (e.g.
Zotero.Exception.UnloadedDataException) is thrown without the debugger enabled, it can be logged as a non-descriptive[JavaScript Error: "uncaught exception: Object"].This stringifies the exception object and puts the string into the message, so that the actual error and the stacktrace are not lost.
Initially brought up in #5163 (comment).
For a recent minimal example, this is a debug ID with the
Zotero.Exception.UnloadedDataExceptiontriggered on current beta: D1339492968. Notice no information but[JavaScript Error: "uncaught exception: Object"]at the top.For comparison, the debug ID from this PR D592550858 has JSON stringified "Item ... not yet loaded" error message.