[EXTERNAL] Update README.md in ascii-art subject (typos in examples) #2994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typos in the examples given: - Fixes space length (6pixels+2 for separating chars) in examples that include space character - Fixes missing space after "2" char in "1Hello 2There" example
|
@motonai I agree with your PR except for the
So the separating spaces should be Here is the corrected version: student$ go run . "Hello There" | cat -e
_ _ _ _ _______ _ $
| | | | | | | | |__ __| | | $
| |__| | ___ | | | | ___ | | | |__ ___ _ __ ___ $
| __ | / _ \ | | | | / _ \ | | | _ \ / _ \ | '__| / _ \ $
| | | | | __/ | | | | | (_) | | | | | | | | __/ | | | __/ $
|_| |_| \___| |_| |_| \___/ |_| |_| |_| \___| |_| \___| $
$
$
student$ go run . "1Hello 2There" | cat -e
_ _ _ _ _______ _ $
_ | | | | | | | | ____ |__ __| | | $
/ | | |__| | ___ | | | | ___ |___ \ | | | |__ ___ _ __ ___ $
| | | __ | / _ \ | | | | / _ \ __) | | | | _ \ / _ \ | '__| / _ \ $
| | | | | | | __/ | | | | | (_) | / __/ | | | | | | | __/ | | | __/ $
|_| |_| |_| \___| |_| |_| \___/ |_____| |_| |_| |_| \___| |_| \___| $
$
$
student$ go run . "{Hello There}" | cat -e
__ _ _ _ _ _______ _ __ $
/ / | | | | | | | | |__ __| | | \ \ $
| | | |__| | ___ | | | | ___ | | | |__ ___ _ __ __<
8000
span class="pl-s">_ | | $
/ / | __ | / _ \ | | | | / _ \ | | | _ \ / _ \ | '__| / _ \ \ \ $
\ \ | | | | | __/ | | | | | (_) | | | | | | | | __/ | | | __/ / / $
| | |_| |_| \___| |_| |_| \___/ |_| |_| |_| \___| |_| \___| | | $
\_\ /_/ $
$ |
|
I'll be pushing ASAP. You are correct, I forgot that last space column per letter is coming from the letter itself. Thank you for your feedback. |
|
Seems ready now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typos in the examples given:
Why?
Misleads the student on what output should expect, especially if they use them for unit testing.
Solution Overview
Fixes the spaces
Implementation Details
Adds the spaces needed
Build Images
Not applicable... It's just a README.md