feat: Python bindings now support subclass inheritance for classes #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables subclass inheritance for various Python binding types by adding the subclass flag to #[pyclass] attributes.
- Allowed Python-side subclassing for proxy, multipart, header, cookie, and response classes.
- Updated
#[pyclass]annotations across both async and blocking modules to#[pyclass(subclass)].
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/typing/proxy.rs | Enabled subclassing for Proxy class. |
| src/typing/multipart/part.rs | Enabled subclassing for Part class. |
| src/typing/multipart/form.rs | Enabled subclassing for Multipart class. |
| src/typing/mod.rs | Enabled subclassing for ImpersonateOption struct. |
| src/typing/header.rs | Enabled subclassing for header map and its iterators. |
| src/typing/cookie.rs | Enabled subclassing for Cookie class. |
| src/blocking/response/ws.rs | Enabled subclassing for BlockingWebSocket. |
| src/blocking/response/http.rs | Enabled subclassing for BlockingResponse and streamer. |
| src/async_impl/response/ws/mod.rs | Enabled subclassing for WebSocket class. |
| src/async_impl/response/ws/message.rs | Enabled subclassing for Message class. |
| src/async_impl/response/http.rs | Enabled subclassing for Response and Streamer. |
Comments suppressed due to low confidence (1)
src/blocking/response/http.rs:11
- Typo in doc comment: 'bloking' should be 'blocking'.
/// A bloking response from a request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.