8000 Call Runtime.Flush() by YoshihiroIto · Pull Request #5 · 0xd4d/JitDasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 10, 2021. It is now read-only.

Call Runtime.Flush() #5

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Call Runtime.Flush() #5

merged 1 commit into from
Jan 27, 2020

Conversation

YoshihiroIto
Copy link
Contributor

When COMPlus_TieredCompilation = 0, the output result is random.
I fixed this problem.

>set COMPlus_TieredCompilation=0
>JitDasm -l Test.dll
>JitDasm -l Test.dll
>JitDasm -l Test.dll

@0xd4d
Copy link
Collaborator
0xd4d commented Jan 27, 2020

What OS did you test it on?

I tested it on Windows and even with this fix, it randomly disassembles methods. I don't think it's a JitDasm issue, looks like it could be a CLRMD issue.

I also got a hang in CLRMD:

 	Microsoft.Diagnostics.Runtime.dll!Microsoft.Diagnostics.Runtime.DacInterface.SOSDac.GetMethodDescData(ulong md, ulong ip, out Microsoft.Diagnostics.Runtime.DacInterface.MethodDescData data)	Unknown
 	Microsoft.Diagnostics.Runtime.dll!Microsoft.Diagnostics.Runtime.Desktop.V45MethodDescDataWrapper.Init(Microsoft.Diagnostics.Runtime.DacInterface.SOSDac sos, ulong md)	Unknown
 	Microsoft.Diagnostics.Runtime.dll!Microsoft.Diagnostics.Runtime.Desktop.V45Runtime.GetMethodDescData(ulong md)	Unknown
 	Microsoft.Diagnostics.Runtime.dll!Microsoft.Diagnostics.Runtime.Desktop.DesktopHeapType.Methods.get()	Unknown
>	JitDasm.dll!JitDasm.Program.GetMethodsToDisassemble(int pid, string moduleName, JitDasm.MemberFilter typeFilter, JitDasm.MemberFilter methodFilter, bool heapSearch) Line 291	C#
 	JitDasm.dll!JitDasm.Program.Main(string[] args) Line 53	C#

@YoshihiroIto
Copy link
Contributor Author

Thank you for your reply.

My OS is also Windows.

> ver
Microsoft Windows [Version 10.0.18363.592]

I tested it on Windows and even with this fix, it randomly disassembles methods. I don't think it's a JitDasm issue, looks like it could be a CLRMD issue.

OK.
I will continue to track this issue in my environment. I will also check the status of CLRMD.

I want to tell you something.
I made GUI wrapper to make JitDasm more efficient. This could be made thanks to your great works. Thank you very much.

https://github.com/YoshihiroIto/JitPad

@0xd4d
Copy link
Collaborator
0xd4d commented Jan 27, 2020

Never mind, I got it working. Your fix fixes this problem.

@0xd4d 0xd4d merged commit 4734e97 into 0xd4d:master Jan 27, 2020
@0xd4d
Copy link
Collaborator
0xd4d commented Jan 27, 2020

Thanks for the fix!

@YoshihiroIto YoshihiroIto deleted the fix-method-enum-problem-on-COMPlus_TieredCompilation=0 branch January 27, 2020 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoshihiroIto @0xd4d
0