8000 Fix some ruff rules mesh, remesh and report modules by kmarchais · Pull Request #70 · 3MAH/microgen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some ruff rules mesh, remesh and report modules #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 10, 2024
Merged

Fix some ruff rules mesh, remesh and report modules #70

merged 13 commits into from
Dec 10, 2024
+326 −160

Conversation

kmarchais
Copy link
Member
@kmarchais kmarchais commented May 30, 2024 •
edited
Loading
  • Fix some ruff rules
  • Create mesh_periodic that will replace meshPeriodic
  • Deprectaing listPhases and mshFileVersion and replacing by list_phases and msh_file_version in mesh and mesh_periodic
  • Refactor is_periodic

@kmarchais kmarchais marked this pull request as ready for review May 31, 2024 21:31
@chemiskyy chemiskyy removed the request for review from ricardo0115 December 10, 2024 09:44
chemiskyy
chemiskyy reviewed Dec 10, 2024
View reviewed changes
Copy link
Member
@chemiskyy chemiskyy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to resolve conflits

@chemiskyy chemiskyy merged commit 5778da9 into main Dec 10, 2024
13 checks passed
@chemiskyy chemiskyy deleted the fix/ruff-mesh-remesh-report branch December 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemiskyy chemiskyy chemiskyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmarchais @chemiskyy
0