8000 Drop python 3.8 support by kmarchais · Pull Request #84 · 3MAH/microgen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Drop python 3.8 support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

Drop python 3.8 support #84

merged 1 commit into from
Dec 9, 2024

Conversation

kmarchais
Copy link
Member
@kmarchais kmarchais commented Oct 28, 2024 •
edited
Loading

This PR is dropping support of Python 3.8 following its end of life since October 14th (Status of Python versions).

@kmarchais kmarchais requested review from ricardo0115 and chemiskyy and removed request for ricardo0115 October 28, 2024 09:59
chemiskyy
chemiskyy reviewed Dec 9, 2024
View reviewed changes
Copy link
Member
@chemiskyy chemiskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is clean and remove all unncessary annotations using external imports.
The use of Optional has been replaced with : X | None which is advised for Python 3.10+
from future import annotations is imported to keep support for Python 3.9

ricardo0115
ricardo0115 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator
@ricardo0115 ricardo0115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmarchais kmarchais merg 7DDE ed commit 08e080f into main Dec 9, 2024
13 checks passed
@kmarchais kmarchais deleted the maint/drop-python-3.8 branch December 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemiskyy chemiskyy chemiskyy left review comments

@ricardo0115 ricardo0115 ricardo0115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmarchais @chemiskyy @ricardo0115
0