Refactor remesh.py and bug fixes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to replace code duplication, a double for loop iterating over rve boundaries and has been implemented using lazy evaluation to check if a triangle given as parameter is on boundary of a rve passed in parameter. Further improvement can be potentially done using numpy.is_close over node coordinates.
Bug related to useless list comprehension instead of generator comprehension could conduct to unexpected behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
_is_triangle_on_boundarymethod ofremesh.pymodule.Code duplication has been removed using comprehension generators and boundary triangle check has been optimized in best case complexity scenario using lazy evaluation.
Bug fixes
test_remesh.pyleading to a false positive test.