8000 Compatibility improvements by kmarchais · Pull Request #23 · 3MAH/microgen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Compatibility improvements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 6, 2024
Merged

Compatibility improvements #23

merged 17 commits into from
Mar 6, 2024

Conversation

kmarchais
Copy link
Member
@kmarchais kmarchais commented Oct 23, 2023 •
edited
Loading

Overview

The aim of this PR is to improve the compatibility of microgen for python versions from 3.8 to 3.11.

  • Use of the type hints Dict, List, Tuple instead of dict, list, tuple for compatibility with python 3.8.
  • Use of | instead of Union for typing and addition of the line from __future__ import annotations for compatibility with versions < 3.10
  • "Build and Test" workflow updated to test microgen with versions 3.8 and 3.11 of python.
  • Microgen can't be compatible with Python 3.12 because OCP is not available with pip for 3.12

@kmarchais kmarchais requested review from chemiskyy and ricardo0115 and removed request for chemiskyy and ricardo0115 October 23, 2023 14:11
@kmarchais kmarchais marked this pull request as draft October 25, 2023 15:07
@kmarchais kmarchais marked this pull request as ready for review December 11, 2023 14:14
@ricardo0115 ricardo0115 merged commit 7697630 into main Mar 6, 2024
@ricardo0115 ricardo0115 deleted the test-python-versions branch March 6, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemiskyy chemiskyy Awaiting requested review from chemiskyy

@ricardo0115 ricardo0115 Awaiting requested review from ricardo0115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmarchais @ricardo0115
0