migrate circleci ubuntu to ubuntu-2004:202201-02 #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStokluska
reviewed
Feb 23, 2022
| @@ -96,3 +96,5 @@ _output | |||
|
|
|||
| # controller-runtime testenv binaries | |||
| testbin/* | |||
|
|
|||
| 3scale-operator | |||
There was a problem hiding this comment.
hey Eguzki, why are we adding 3scale-operator to gitignore?
There was a problem hiding this comment.
My IDE (vim) when compiling the code from the main.go generates the binary 3scale-operator file at the root of the project.
|
Looking at the circle docs https://discuss.circleci.com/t/linux-machine-executor-images-2022-january-q1-update/42831 it makes sense to do it, just a question about ignoring 3scale-operator to have a better understanding of what's happening. |
f952e06 to
d8716c7
Compare
|
Code Climate has analyzed commit d8716c7 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 16.04-based image used in circleCI is deprecated and near EOL. Migrating to ubuntu-2004:202201-02
https://circleci.com/blog/ubuntu-14-16-image-deprecation/?mkt_tok=NDg1LVpNSC02MjYAAAGCndaS4T7Scgi7c4rB8r6g0bSsqoPY_E5GHWHcYzyRMlDS4oeY1FBTMWliNblf0MAFDvP7ae5x3Qms-6fj3_3WMthRMTB2AJHtYJnSZeld5tQ