apimanager CRD: preserve unknown fields #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit faf753c and detected 0 issues on this pull request. View more on Code Climate. |
thomasmaas
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apimanager CRD: add x-kubernetes-preserve-unknown-fields to disable pruning
Related issue: https://issues.redhat.com/browse/THREESCALE-8445
Ideally, unknown fields should be pruned and bump CRD version. Check comment: https://issues.redhat.com/browse/THREESCALE-8445?focusedCommentId=20369075&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-20369075
This PR prevents from issues as low effort good compromise