[Backport #811 MGDAPI-5152] remove duplicate env #816
Conversation
…nfigRemoveDuplicateEnvVarMutator
| } | ||
| } | ||
|
|
||
| return result |
There was a problem hiding this comment.
Help me understand where in this function the env vars are actually removed.
There was a problem hiding this comment.
The map has the property that the map keys are unique. The method will iterate over all the env vars and try to create a map of env var key to the same env var.
{env var key A} -> {env var A}
{env var key B} -> {env var B}
{env var key C} -> {env var C}
On each iteration of the loop, the map can tell if the key has been inserted before or not (line 17) (in O(1) time). When there are duplicated env vars, the loop will try to insert the same key multiple times in the map. Only the first time will succeed. After that, when a duplicated key is found, the conditional (line 17) will evaluate to false and the duplicated env var will not be added to the list of env vars that is returned by the method.
What
Provides support for OCP 4.13 for 3scale 2.13
Fix in master #811