10000 THREESCALE-7836 Exposed new env var to set porta client insecureSkipVerify flag by carlkyrillos · Pull Request #856 · 3scale/3scale-operator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

THREESCALE-7836 Exposed new env var to set porta client insecureSkipVerify flag #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

THREESCALE-7836 Exposed new env var to set porta client insecureSkipVerify flag #856

merged 1 commit into from
Aug 16, 2023

Conversation

carlkyrillos
Copy link
Contributor
@carlkyrillos carlkyrillos commented Aug 9, 2023 •
edited
Loading

Issue link

THREESCALE-7836

What

Refactors the PortaClient to default the TLS InsecureSkipVerify flag to false and exposes a new environment variable, INSECURE_SKIP_VERIFY_CLIENT that if 1 will set the InsecureSkipVerify to true.

Verification steps

  1. Provision a cluster
  2. Checkout this branch
  3. Deploy 3scale using prebuilt bundle image:
make bundle-run BUNDLE_IMG=quay.io/ckyrillos/3scale-operator-bundles:threescale-7836
  1. Once the installation is complete, add the following environment variable to the ClusterServiceVersion:
- name: INSECURE_SKIP_VERIFY_CLIENT
  value: '1'
  1. Run the e2e tests and confirm they pass:
make test-e2e
  1. Edit the ClusterServiceVersion again, this time setting the environment variable to 0:
- name: INSECURE_SKIP_VERIFY_CLIENT
  value: '0'
  1. Run the e2e tests again and confirm they still pass:
make test-e2e

@carlkyrillos carlkyrillos requested a review from a team as a code owner August 9, 2023 18:41
@openshift-ci
Copy link
openshift-ci bot commented Aug 9, 2023

Hi @carlkyrillos. Thanks for your PR.

I'm waiting for a 3scale member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codeclimate
Copy link
codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 504d898 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@valerymo
Copy link
Contributor
valerymo commented Aug 10, 2023 •
edited
Loading

@carlkyrillos , it looks good to me.

@valerymo
Copy link
Contributor

/lgtm

@austincunningham
Copy link
Contributor

/ok-to-test

@MStokluska
Copy link
Contributor

/lgtm

austincunningham
austincunningham approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor
@austincunningham austincunningham left a comment

Choose a reason fo 8000 r hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@austincunningham austincunningham merged commit 2c8a019 into 3scale:master Aug 16, 2023
@MStokluska
Copy link
Contributor

@carlkyrillos can you add documentation as well please

@carlkyrillos carlkyrillos deleted the THREESCALE-7836 branch August 16, 2023 14:29
@carlkyrillos
Copy link
Contributor Author

@carlkyrillos can you add documentation as well please

@MStokluska I created a followup PR to add documentation

@eguzki eguzki mentioned this pull request Aug 17, 2023
Merged
@briangallagher briangallagher mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincunningham austincunningham austincunningham approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlkyrillos @valerymo @austincunningham @MStokluska
0