THREESCALE-10092 fix promote to stage with false production value #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 2442457 and detected 0 issues on this pull request. View more on Code Climate. |
Verified# product true
oc get proxyconfigpromote product1 -oyaml
apiVersion: capabilities.3scale.net/v1beta1
kind: ProxyConfigPromote
metadata:
creationTimestamp: "2023-10-16T10:26:48Z"
generation: 1
name: product1
namespace: threescale
resourceVersion: "149871"
uid: e3510f1f-a2ec-4318-bcc7-9c5554a0ccdb
spec:
deleteCR: false
productCRName: product1-cr
production: true
status:
conditions:
- lastTransitionTime: "2023-10-16T10:26:48Z"
status: "False"
type: Failed
- lastTransitionTime: "2023-10-16T10:26:48Z"
message: 3scale product has been successfully promoted, any further interactions
with this CR (apart from deletion) won't be applied
status: "True"
type: Ready
latestProductionVersion: 1
latestStagingVersion: 1
productId: "13"
# product false
oc get proxyconfigpromote product2 -oyaml
apiVersion: capabilities.3scale.net/v1beta1
kind: ProxyConfigPromote
metadata:
creationTimestamp: "2023-10-16T10:27:15Z"
generation: 1
name: product2
namespace: threescale
resourceVersion: "150100"
uid: 2b4ef63b-e5fd-4bcd-9e22-5e8a998860b6
spec:
deleteCR: false
productCRName: product2-cr
production: false
status:
conditions:
- lastTransitionTime: "2023-10-16T10:27:15Z"
status: "False"
type: Failed
- lastTransitionTime: "2023-10-16T10:27:15Z"
message: 3scale product has been successfully promoted, any further interactions
with this CR (apart from deletion) won't be applied
status: "True"
type: Ready
latestStagingVersion: 1
productId: "14"
# no product value set
oc get proxyconfigpromote product3 -oyaml
apiVersion: capabilities.3scale.net/v1beta1
kind: ProxyConfigPromote
metadata:
creationTimestamp: "2023-10-16T10:27:36Z"
generation: 1
name: product3
namespace: threescale
resourceVersion: "150268"
uid: 4eed07e9-d4fa-4854-a62b-3502348593a9
spec:
deleteCR: false
productCRName: product3-cr
status:
conditions:
- lastTransitionTime: "2023-10-16T10:27:37Z"
status: "False"
type: Failed
- lastTransitionTime: "2023-10-16T10:27:37Z"
message: 3scale product has been successfully promoted, any further interactions
wit
8000
h this CR (apart from deletion) won't be applied
status: "True"
type: Ready
latestStagingVersion: 1
productId: "15"
|
austincunningham
approved these changes
Oct 16, 2023
eguzki
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #863
Verification:
Follow steps from the previous PR as follow up.
Add another case where the proxyConfigPromote created only promotes to stage but with production set to false.
Example: