Add a hidden whitelist file for using unsupported ROMs #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab9057 to
868273f
Compare
This allows users to specify additional file hashes and/or file names that the bot should support. That can be done by adding the hash and/or file name to `profiles/extra_allowed_roms.txt` (a file that does not exist by default.) Doing so allows users to make minor modifications to ROMs as long as they don't change memory offsets. There are several warnings, both in the Wiki and in the bot itself, that there will be no help when using unsupported files.
1d30510 to
1660551
Compare
pekempy
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to specify additional file hashes and/or file names that the bot should support.
That can be done by adding the hash and/or file name to
profiles/extra_allowed_roms.txt(a file that does not exist by default.)Doing so allows users to make minor modifications to ROMs as long as they don't change memory offsets.
There are several warnings, both in the Wiki and in the bot itself, that there will be no help when using unsupported files.
Notes
A new version of Black kept complaining about the existing code, so I've fixed these issues in this PR as well in order to get the check to pass.
Checklist
--line-length 120argument