Support nicknaming hatched Pokémon (through plugins) #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already supported nicknaming Pokémon that have been caught from wild or static encounters. This change adds that feature to egg hatching as well. A plugin is needed to actually use this feature, same as before.
There was a problem hiding this comment.
Pull Request Overview
This PR expands Pokémon nicknaming support to include egg hatching by propagating encounter information changes to the nicknaming plugin system. Key changes include updating function signatures and documentation in plugins and plugin interfaces, integrating the new nicknaming flow into egg hatching logic in the battle and listener modules, and adding a new keyboard handler for the naming screen.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/plugins.py | Updated the parameter type for nickname plugins to use EncounterInfo instead of Pokémon. |
| modules/plugin_interface.py | Refactored the on_should_nickname_pokemon signature and docstrings to match the new parameter type. |
| modules/modes/_listeners.py | Integrated nicknaming during egg hatching by calling the new naming screen handler. |
| modules/map.py | Added a fallback return value and a new facing_coordinates property for map objects. |
| modules/keyboard.py | Introduced handle_naming_screen for handling in-game nickname input via the keyboard. |
| modules/battle_handler.py | Modified nickname handling in battle to require an encounter parameter and streamlined the naming logic. |
ThibaultLassiaz
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already supported nicknaming Pokémon that have been caught from wild or static encounters.
This change adds that feature to egg hatching as well.
A plugin is needed to actually use this feature, same as before.
Notes
This introduces a backwards-incompatible change by changing the plugin interface's
on_should_nickname_pokemonfunction to accept anEncounterInfoinstance rather than just aPokemon.The
EncounterInfoclass has the Pokémon as a property, so it's still available and would need minimal code changes (pokemon = encounter.pokemon)If anyone has even bothered to write a plugin for that, I'm sure they'll have the expertise to adapt it accordingly.
Checklist
--line-length 120argument