Add macos arm wheels #18
Conversation
WalkthroughThis update involves expanding the testing environment to include macOS 14 in the workflow configurations and updating the git clone command to fetch a specific branch ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/wheels.yml (1 hunks)
- build_utils/build_libomp.sh (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/wheels.yml
Additional comments: 1
build_utils/build_libomp.sh (1)
- 5-5: The update to fetch the
llvmorg-17.0.6branch of the LLVM project is correct and aligns with the PR objectives to adapt to newer dependencies and toolchains.
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | ||
| build_dir=${DIR}/libs_build | ||
|
|
||
| git clone --depth 1 --branch llvmorg-11.1.0 https://github.com/llvm/llvm-project | ||
| git clone --depth 1 --branch llvmorg-17.0.6 https://github.com/llvm/llvm-project | ||
| pushd llvm-project/openmp | ||
| mkdir build | ||
| cd build |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-14]
Consider adding error handling for the commands used in this script. For instance, checking the exit status of git clone, cmake, and make commands can prevent proceeding with the script when an error occurs, enhancing the robustness of the build process.
+ set -eAdding set -e at the beginning of the script will cause the script to exit immediately if a command exits with a non-zero status.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-14]
It's good practice to check if the required tools (git, cmake, clang, make) are available before proceeding with the build process. This can be done by adding simple checks at the beginning of the script.
+ command -v git >/dev/null 2>&1 || { echo >&2 "git is required but it's not installed. Aborting."; exit 1; }
+ command -v cmake >/dev/null 2>&1 || { echo >&2 "cmake is required but it's not installed. Aborting."; exit 1; }
+ command -v clang >/dev/null 2>&1 || { echo >&2 "clang is required but it's not installed. Aborting."; exit 1; }
+ command -v make >/dev/null 2>&1 || { echo >&2 "make is required but it's not installed. Aborting."; exit 1; }Adding these checks ensures that the script only proceeds if all necessary tools are installed, preventing potential build failures and providing clear error messages to the user.
|
After local tests, it looks working |
Summary by CodeRabbit
llvmorg-17.0.6).