ci: Fix tests for napari from repository #1148
Conversation
WalkthroughThe updates encompass various components, highlighting significant enhancements and refinements. Key changes include adding support for Python 3.12 in workflows, refining dependencies and test commands in Changes
Sequence Diagram(s)No sequence diagrams are generated for this set of changes as they primarily involve configuration updates, dependency management, and minor code adjustments rather than significant new features or control flow modifications. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/test_napari_repo.yml (2 hunks)
- tox.ini (2 hunks)
Additional comments not posted (4)
.github/workflows/test_napari_repo.yml (2)
8-12: Added pull_request trigger for specific paths.This change ensures that the workflow is triggered for pull requests that modify critical paths, enhancing the CI process by ensuring relevant tests are run when these files are changed.
37-37: Expanded Python version matrix to include 3.12.This change ensures that the workflow tests against the latest Python version, which is crucial for maintaining compatibility and catching issues early.
tox.ini (2)
42-42: Updated PySide6 dependency specification.This change is a straightforward update to the PySide6 dependency, likely to address compatibility issues or new features in PySide6.
74-87: Updated environment configurations and commands for different napari versions.This comprehensive update includes:
- Addition of napari version 0.5.0 in the testing matrix.
- Adjustments to the dependency specifications for different napari versions.
- Modification of test commands based on whether the napari repository is present.
These changes are crucial for ensuring that the testing environments are accurately configured to test against multiple versions of napari, which is essential for compatibility testing.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tox.ini (2 hunks)
Additional comments not posted (2)
tox.ini (2)
42-43: Update PySide6 version constraints based on Python version.The conditional version constraints for PySide6 are correctly updated to handle different Python versions. This ensures compatibility and prevents potential issues with newer Python releases.
75-88: Review updated test environments and commands.The test environment configurations and commands have been updated to include a new napari version (
napari_5) and to reflect the renaming of napari version identifiers. These changes are consistent with the PR objectives to fix tests related to the napari repository.
- Python Version and Dependency Management: The addition of Python 3.12 in the test matrix is a forward-looking change that prepares the testing infrastructure for future Python releases.
- Dependency Constraints: The use of
pydantic<2for specific napari versions suggests careful management of dependencies to avoid potential compatibility issues.- Test Commands: The differentiation in test commands between
napari_repoand other versions is logical, allowing for more comprehensive testing when working directly with the napari repository.Overall, these updates are well-structured and seem to align with best practices for maintaining a robust testing environment.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/test_napari_repo.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test_napari_repo.yml
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/test_napari_widgets.yml (1 hunks)
- package/tests/conftest.py (1 hunks)
- package/tests/test_PartSeg/test_base_widgets.py (1 hunks)
- pyproject.toml (1 hunks)
- tox.ini (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- tox.ini
Additional comments not posted (4)
.github/workflows/test_napari_widgets.yml (1)
30-30: Update to Napari version approved, but verify compatibility.The update from "napari419" to "napari5" is noted. While this change is approved, it's crucial to verify that "napari5" is compatible with the existing dependencies and does not introduce any breaking changes.
package/tests/test_PartSeg/test_base_widgets.py (1)
109-109: Decorator to skip tests on PySide6 added.The addition of
@pytest.mark.pyside6_skip()is approved. However, it's important to document the reasons for skipping these tests when using PySide6 to maintain clarity for future maintenance.pyproject.toml (1)
208-209: Markers for skipping tests based on Qt backend added.The addition of
pyside_skipandpyside6_skipmarkers is approved. It's important to verify that these markers are utilized correctly throughout the test suite to ensure they function as intended.Verification successful
Markers for skipping tests based on Qt backend added.
The addition of
pyside_skipandpyside6_skipmarkers is approved. The markers are correctly utilized throughout the test suite to ensure they function as intended.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify usage of new test markers in the test suite. # Test: Search for usage of the new markers in test files. rg --type py -A 5 $'pyside_skip|pyside6_skip'Length of output: 10216
package/tests/conftest.py (1)
284-288: Logic to skip tests based on PySide6 added.The addition of logic to skip tests when
qtpy.API_NAMEis "PySide6" is noted and approved. It's important to verify that this logic works as intended and does not interfere with other test configurations.Verification successful
Logic to skip tests based on PySide6 added.
The addition of logic to skip tests when
qtpy.API_NAMEis "PySide6" is correctly implemented. Thepyside6_skipmarker is properly referenced in the codebase, and the logic does not interfere with other test configurations.
pyproject.toml: Definition ofpyside6_skipmarker.package/tests/conftest.py: Implementation of the logic to skip tests.package/tests/test_PartSeg/test_base_widgets.py: Usage of thepyside6_skipmarker.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new test skipping logic in action. # Test: Run tests to ensure they are skipped as expected under PySide6. pytest -k "pyside6_skip" --collect-onlyLength of output: 113
Script:
#!/bin/bash # Search for the usage of the 'pyside6_skip' marker in the codebase to ensure it is correctly implemented. # Find occurrences of 'pyside6_skip' in the codebase rg 'pyside6_skip' # Verify the logic in 'conftest.py' to ensure it does not interfere with other configurations rg 'def ' package/tests/conftest.py -A 10Length of output: 8365
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- package/tests/test_PartSeg/test_base_widgets.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- package/tests/test_PartSeg/test_base_widgets.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1148 +/- ##
===========================================
+ Coverage 93.02% 93.03% +0.01%
===========================================
Files 207 207
Lines 32705 32700 -5
===========================================
- Hits 30425 30424 -1
+ Misses 2280 2276 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- package/tests/test_PartSeg/test_base_widgets.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- package/tests/test_PartSeg/test_base_widgets.py
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
package/PartSeg/common_gui/colormap_creator.py (1)
423-425: Check signal connections inChannelPreview.__init__.The connection logic for
edit_request_nameandedit_request_colormapis correctly implemented. However, ensure that the conditions under which theedit_btnis disabled (i.e., whencolormap.controlslength is less than 20) are explicitly documented to avoid confusion.+ # Disable edit button if the number of controls in the colormap is less than 20 if len(colormap.controls) < 20: self.edit_btn.clicked.connect(partial(self.edit_request_colormap.emit, colormap)) self.edit_btn.setToolTip("Create colormap base on this") else: self.edit_btn.setDisabled(True) self.edit_btn.setToolTip("This colormap is not editable")
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- package/PartSeg/common_gui/colormap_creator.py (4 hunks)
- package/tests/conftest.py (1 hunks)
Additional comments not posted (2)
package/tests/conftest.py (1)
290-294: Ensure proper skipping of tests based on Qt backend.The code correctly checks for the "pyside6_skip" marker and skips the test if the Qt backend is PySide6. This change aligns with the PR's goal to improve CI testing compatibility.
package/PartSeg/common_gui/colormap_creator.py (1)
384-385: Properly split edit request signals for clarity.The signals
edit_request_nameandedit_request_colormapare well-defined, enhancing modularity and clarity in signal handling. This change supports better separation of concerns, allowing distinct handling for name and colormap modifications.
|
Summary by CodeRabbit
New Features
napariversion 0.5.0.napari5.Bug Fixes
PySide6and other Python versions.edit_requestsignals in the Colormap Creator.Chores
PySide6to enhance test management.