8000 fix: Prevent propagation of decreasing contrast limits set by user by Czaki · Pull Request #1166 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Prevent propagation of decreasing contrast limits set by user #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: Prevent propagation of decreasing contrast limits set by user #1166

merged 1 commit into from
Jul 23, 2024

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Jul 23, 2024 •
edited by coderabbitai bot
Loading

fix PARTSEG-VC

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced data validation in the channel control, ensuring only valid ranges are processed.
    • Improved locking mechanism for widgets, preventing erroneous states by validating range conditions.

  • Bug Fixes

    • Addressed issues in the get_limits method, ensuring only proper tuples are returned.

@Czaki Czaki added this to the 0.15.4 milestone Jul 23, 2024
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 23, 2024 •
edited
Loading

Walkthrough

The recent changes enhance data validation and control flow within the channel_control.py file. The get_limits method now ensures that only valid ranges are returned, while the parameters_changed method improves the locking mechanism by validating range conditions. These updates contribute to a more robust and error-resistant functionality, ultimately promoting better data integrity and user experience.

Changes

Files Change Summary
.../common_gui/channel_control.py Improved get_limits to filter out invalid ranges and refined parameters_changed for enhanced lock validation based on range conditions.

Poem

🐰 In the code where limits sway,
A rabbit hops and saves the day.
With ranges checked and locks now tight,
Our data dances, oh what a sight!
So let’s rejoice, with code so fine,
A leap of joy, all in a line! 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Jul 23, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Czaki Czaki force-pushed the block_decreasing_contast_limits branch from 4f6826f to e5fd0ac Compare July 23, 2024 12:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai[bot]
coderabbitai bot reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2b9ecf and 4f6826f.

Files selected for processing (1)
  • package/PartSeg/common_gui/channel_control.py (2 hunks)
Additional comments not posted (2)
package/PartSeg/common_gui/channel_control.py (2)

652-655: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to parameters_changed handle the new validation logic correctly.

Verification successful

LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to parameters_changed handle the new validation logic correctly:

  • package/PartSeg/common_gui/channel_control.py
  • package/tests/test_PartSeg/test_channel_control.py
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `parameters_changed` handle the new validation logic correctly.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type python -A 5 $'parameters_changed'

Length of output: 73

Script:

#!/bin/bash
# Description: Verify all function calls to `parameters_changed` handle the new validation logic correctly.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type py -A 5 'parameters_changed'

Length of output: 2406

635-635: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to get_limits handle the new filtering logic correctly.

@Czaki
Copy link
Collaborator Author
Czaki commented Jul 23, 2024

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 23, 2024
Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codecov Codecov
Copy link
codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (f2b9ecf) to head (e5fd0ac).
Report is 46 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1166   +/-   ##
========================================
  Coverage    93.06%   93.06%           
========================================
  Files          209      209           
  Lines        32829    32831    +2     
========================================
+ Hits         30552    30554    +2     
  Misses        2277     2277

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki
Copy link
Collaborator Author
Czaki commented Jul 23, 2024

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 23, 2024
Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai bot reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f6826f and e5fd0ac.

Files selected for processing (1)
  • package/PartSeg/common_gui/channel_control.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • package/PartSeg/common_gui/channel_control.py

@Czaki Czaki merged commit 2366990 into develop Jul 23, 2024
57 checks passed
@Czaki Czaki deleted the block_decreasing_contast_limits branch July 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.4
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0