8000 chore: Switch to `get_qapp` from `get_app` to handle napari deprecation by Czaki · Pull Request #1249 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Switch to get_qapp from get_app to handle napari deprecation #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2025
Merged

chore: Switch to get_qapp from get_app to handle napari deprecation #1249

merged 4 commits into from
Mar 10, 2025

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Mar 10, 2025 •
edited by coderabbitai bot
Loading

Summary by Sourcery

Enhancements:

  • Handle napari deprecation by switching to get_qapp and falling back to get_app for older versions.

Summary by CodeRabbit

  • Chore
    • Enhanced compatibility with the Napari library to ensure reliable application startup across different versions.
    • Updated version number for personal_ws and added a new project entry for qapp.

@Czaki Czaki added this to the 0.16.1 milestone Mar 10, 2025
@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Mar 10, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request addresses the deprecation of get_app in newer versions of napari by switching to get_qapp. It includes a try-except block to ensure compatibility with older napari versions where get_qapp is not available.

Sequence diagram for napari application initialization

sequenceDiagram
    participant PartSeg
    participant napari.qt

    PartSeg->>napari.qt: try: get_qapp()
    alt napari >= 0.5.4
        napari.qt-->>PartSeg: Returns QApplication instance
    else napari < 0.5.4
        PartSeg->>napari.qt: except ImportError: get_app()
        napari.qt-->>PartSeg: Returns QApplication instance
    end
Loading

File-Level Changes

Change Details Files
Replaced get_app with get_qapp to address napari deprecation, using a try-except block to maintain compatibility with older napari versions.
  • Import get_qapp from napari.qt for napari versions 0.5.4 and later.
  • Fallback to get_app for older napari versions using a try-except block.
  • Call get_qapp() instead of get_app() to initialize the Qt application.
 package/PartSeg/launcher_main.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Mar 10, 2025 •
edited
Loading

Walkthrough

This change updates the application initialization in the launcher. The _test_imports function now attempts to import get_qapp from napari.qt (for Napari 0.5.4+). If this import fails with an ImportError, it falls back to importing get_app and aliases it as get_qapp. Consequently, the function now calls get_qapp() to retrieve the Napari application instance regardless of the Napari version. Additionally, the version number in the project dictionary has been updated, and a new entry has been added.

Changes

File Change Summary
package/PartSeg/launcher_main.py Updated import statements and function calls in _test_imports to first try get_qapp from napari.qt and fall back t 8000 o get_app if needed.
.github/project_dict.pws Updated version number from 1.1 en 17 to 1.1 en 18 and added a new entry qapp at the end of the file.

Sequence Diagram(s)

sequenceDiagram
    participant Launcher as _test_imports
    participant Napari as napari.qt Module

    Launcher->>Napari: Import get_qapp
    alt get_qapp available
        Napari-->>Launcher: Return get_qapp
        Launcher->>Launcher: Call get_qapp() to obtain app instance
    else ImportError raised
        Launcher->>Napari: Import get_app (alias as get_qapp)
        Napari-->>Launcher: Return get_app
        Launcher->>Launcher: Call get_qapp() (alias for get_app) to obtain app instance
    end
Loading

Poem

I hopped through lines of Python code,
Dancing with imports on a curious road.
When new meets old in Napari's dance,
I leap with joy at every chance.
Bug-free and light, my code sings—a hopping marvel in digital springs! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c92740f and 9d0521b.

📒 Files selected for processing (1)
  • .github/project_dict.pws (2 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (15)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
  • GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
  • GitHub Check: 4DNucleome.PartSeg (Builds sdist)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
  • GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
  • GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
  • GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: semgrep/ci
🔇 Additional comments (2)
.github/project_dict.pws (2)

1-1: Version number correctly updated.

The version number has been incremented from 17 to 18, which is appropriate when adding new terms to the project dictionary.

19-19: Term "qapp" appropriately added to the dictionary.

Adding "qapp" to the project dictionary is consistent with the PR objective of switching from get_app to get_qapp to handle the napari deprecation. This will prevent spell-checking tools from flagging this technical term as an error.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Czaki - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki changed the title Shitch to get_qapp from get_app to handle napari deprecation chore: Switch to get_qapp from get_app to handle napari deprecation Mar 10, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (94e976f) to head (ba1cdc5).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1249   +/-   ##
========================================
  Coverage    93.15%   93.15%           
========================================
  Files          210      210           
  Lines        33288    33288           
========================================
  Hits         31009    31009           
  Misses        2279     2279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Czaki Czaki merged commit 80131f6 into develop Mar 10, 2025
55 checks passed
@Czaki Czaki deleted the get_qapp branch March 10, 2025 10:55
@coderabbitai coderabbitai bot mentioned this pull request Mar 10, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0