8000 Update names of AdditionalLayerDescription if missed in SegmentationResult by Czaki · Pull Request #233 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update names of AdditionalLayerDescription if missed in SegmentationResult #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

Update names of AdditionalLayerDescription if missed in SegmentationResult #233

merged 1 commit into from
Mar 25, 2021

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Mar 25, 2021

set name for AdditionalLayerDescription is not set to the key of SegmentationResult.additional_layers

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Mar 25, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.11%.

Quality metrics Before After Change
Complexity 1.50 ⭐ 1.64 ⭐ 0.14 👎
Method Length 28.75 ⭐ 29.36 ⭐ 0.61 👎
Working memory 6.36 🙂 6.32 🙂 -0.04 👍
Quality 85.95% ⭐ 85.84% ⭐ -0.11% 👎
Other metrics Before After Change
Lines 183 188 5
Changed files Quality Before Quality After Quality Change
package/PartSegCore/segmentation/algorithm_base.py 85.95% ⭐ 85.84% ⭐ -0.11% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/segmentation/algorithm_base.py SegmentationAlgorithm.__repr__ 3 ⭐ 77 🙂 15 😞 61.43% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/algorithm_base.py SegmentationResult.__str__ 0 ⭐ 51 ⭐ 21 ⛔ 63.47% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/algorithm_base.py SegmentationResult.__repr__ 0 ⭐ 51 ⭐ 21 ⛔ 63.47% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/algorithm_base.py dict_repr 6 ⭐ 71 🙂 10 😞 67.27% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/algorithm_base.py SegmentationAlgorithm.segment_project.set_parameters 1 ⭐ 75 🙂 10 😞 71.60% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link
codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #233 (629edd1) into develop (f273356) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #233   +/-   ##
========================================
  Coverage    67.59%   67.60%           
========================================
  Files          140      140           
  Lines        16801    16804    +3     
========================================
+ Hits         11357    11360    +3     
  Misses        5444     5444
Impacted Files Coverage Δ
package/PartSegCore/segmentation/algorithm_base.py 85.60% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f273356...629edd1. Read the comment docs.

@Czaki Czaki merged commit 463a442 into develop Mar 25, 2021
@Czaki Czaki deleted the bugfix/names_additional branch March 25, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0