8000 fix: change additive to transcluent in rendeerin ROI and Mask by Czaki · Pull Request #472 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: change additive to transcluent in rendeerin ROI and Mask #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix: change additive to transcluent in rendeerin ROI and Mask #472

merged 2 commits into from
Dec 1, 2021

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Dec 1, 2021

No description provided.

@Czaki Czaki added this to the 0.13.14 milestone Dec 1, 2021
@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Dec 1, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.18 ⭐ 5.18 ⭐ 0.00
Method Length 62.47 🙂 62.47 🙂 0.00
Working memory 8.65 🙂 8.65 🙂 0.00
Quality 67.04% 🙂 67.04% 🙂 0.00%
Other metrics Before After Change
Lines 1033 1033 0
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/napari_image_view.py 67.28% 🙂 67.28% 🙂 0.00%
package/PartSeg/plugins/napari_widgets/search_label_widget.py 65.53% 🙂 65.53% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 24 😞 154 😞 11 😞 40.04% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.component_mark 14 🙂 223 ⛔ 11 😞 41.69% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.__init__ 1 ⭐ 524 ⛔ 14 😞 42.51% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView._mark_layer 8 ⭐ 174 😞 13 😞 47.51% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/plugins/napari_widgets/search_label_widget.py SearchLabel._highlight 6 ⭐ 154 😞 14 😞 49.95% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Czaki Czaki merged commit 79aa3aa into develop Dec 1, 2021
@Czaki Czaki deleted the bugfix/change_additive_to_transcluent branch December 1, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.14
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0