8000 fix: Bugs in napari plugins by Czaki · Pull Request #478 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Bugs in napari plugins #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 9, 2021
Merged

fix: Bugs in napari plugins #478

merged 4 commits into from
Dec 9, 2021

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Dec 8, 2021

Properties wrong assignment to components in the measurements
Fiz zoom to in 3D data for Search Label

@Czaki Czaki added this to the 0.13.15 milestone Dec 8, 2021
@codecov
Copy link
codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #478 (a09bde9) into develop (744893e) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #478      +/-   ##
===========================================
+ Coverage    76.88%   76.90%   +0.01%     
===========================================
  Files          144      144              
  Lines        18541    18556      +15     
===========================================
+ Hits         14255    14270      +15     
  Misses        4286     4286
Impacted Files Coverage Δ
...lugins/napari_widgets/roi_extraction_algorithms.py 93.72% <50.00%> (-0.66%) ⬇️
...tSeg/plugins/napari_widgets/search_label_widget.py 91.52% <83.33%> (+1.96%) ⬆️
...ckage/PartSeg/common_gui/algorithms_description.py 72.31% <100.00%> (+0.30%) ⬆️
...rtSeg/plugins/napari_widgets/measurement_widget.py 79.78% <100.00%> (+0.43%) ⬆️
...ge/PartSegCore/analysis/measurement_calculation.py 96.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744893e...a09bde9. Read the comment docs.

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Dec 8, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 3.84 ⭐ 3.87 ⭐ 0.03 👎
Method Length 42.09 ⭐ 42.41 ⭐ 0.32 👎
Working memory 7.23 🙂 7.27 🙂 0.04 👎
Quality 74.51% 🙂 74.34% 🙂 -0.17% 👎
Other metrics Before After Change
Lines 2642 2659 17
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/algorithms_description.py 78.68% ⭐ 78.59% ⭐ -0.09% 👎
package/PartSeg/plugins/napari_widgets/measurement_widget.py 74.38% 🙂 73.63% 🙂 -0.75% 👎
package/PartSeg/plugins/napari_widgets/roi_extraction_algorithms.py 73.25% 🙂 72.52% 🙂 -0.73% 👎
package/PartSeg/plugins/napari_widgets/search_label_widget.py 65.43% 🙂 65.52% 🙂 0.09% 👍
package/PartSegCore/analysis/measurement_calculation.py 73.66% 🙂 73.66% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/analysis/measurement_calculation.py MeasurementProfile.calculate_yield 11 🙂 229 ⛔ 18 ⛔ 34.97% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/plugins/napari_widgets/roi_extraction_algorithms.py ROIExtractionAlgorithms.set_result 13 🙂 206 ⛔ 15 😞 37.71% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/measurement_calculation.py MeasurementResult.get_separated 15 🙂 167 😞 14 😞 40.54% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/measurement_calculation.py MeasurementProfile._calculate_node 13 🙂 198 😞 12 😞 42.55% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/measurement_calculation.py MeasurementProfile._clip_arrays 8 ⭐ 197 😞 11 😞 48.89% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Czaki Czaki merged commit d14b136 into develop Dec 9, 2021
@Czaki Czaki deleted the bugfix/napari_widgets branch December 10, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.15
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0