8000 feat: Assign properties to mask layer in napari measurement widget by Czaki · Pull Request #480 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Assign properties to mask layer in napari measurement widget #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 17, 2021
Merged

feat: Assign properties to mask layer in napari measurement widget #480

merged 7 commits into from
Dec 17, 2021

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Dec 16, 2021

No description provided.

@sourcery-ai sourcery-ai bot mentioned this pull request Dec 16, 2021
Closed
@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Dec 16, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 3.03 ⭐ 3.05 ⭐ 0.02 👎
Method Length 65.55 🙂 65.18 🙂 -0.37 👍
Working memory 8.05 🙂 8.05 🙂 0.00
Quality 70.73% 🙂 70.71% 🙂 -0.02% 👎
Other metrics Before After Change
Lines 5002 5028 26
Changed files Quality Before Quality After Quality Change
package/PartSeg/_roi_analysis/measurement_widget.py 66.11% 🙂 66.50% 🙂 0.39% 👍
package/PartSeg/common_gui/napari_image_view.py 67.19% 🙂 67.19% 🙂 0.00%
package/PartSeg/plugins/napari_widgets/measurement_widget.py 73.63% 🙂 70.23% 🙂 -3.40% 👎
package/PartSegCore/analysis/measurement_calculation.py 73.66% 🙂 73.55% 🙂 -0.11% 👎
package/tests/test_PartSeg/test_analysis.py 77.49% ⭐ 77.34% ⭐ -0.15% 👎
package/tests/test_PartSegCore/test_measurements.py 71.19% 🙂 71.40% 🙂 0.21% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/analysis/measurement_calculation.py MeasurementProfile.calculate_yield 11 🙂 229 ⛔ 18 ⛔ 34.97% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 24 😞 154 😞 11 😞 40.04% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/measurement_calculation.py MeasurementResult.get_separated 15 🙂 170 😞 14 😞 40.25% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/measurement_widget.py MeasurementWidgetBase.__init__ 0 ⭐ 426 ⛔ 17 ⛔ 40.77% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.component_mark 14 🙂 223 ⛔ 11 😞 41.69% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link
codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #480 (1957243) into develop (4f5eda2) will decrease coverage by 0.00%.
The diff coverage is 77.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
- Coverage    76.89%   76.89%   -0.01%     
===========================================
  Files          144      144              
  Lines        18567    18590      +23     
===========================================
+ Hits         14278    14295      +17     
- Misses        4289     4295       +6
Impacted Files Coverage Δ
package/PartSeg/common_gui/napari_image_view.py 85.52% <0.00%> (ø)
...rtSeg/plugins/napari_widgets/measurement_widget.py 77.06% <60.00%> (-2.73%) ⬇️
...ackage/PartSeg/_roi_analysis/measurement_widget.py 81.48% <100.00%> (+0.25%) ⬆️
...ge/PartSegCore/analysis/measurement_calculation.py 96.98% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5eda2...1957243. Read the comment docs.

@Czaki Czaki added this to the 0.13.15 milestone Dec 16, 2021
@Czaki Czaki merged commit 603758f into develop Dec 17, 2021
@Czaki Czaki deleted the feature/set_measurement_feature_to_mask branch December 17, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.15
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0