8000 doc: Add categories and preview page workflow for the napari hub by neuromusic · Pull Request #489 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

doc: Add categories and preview page workflow for the napari hub #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 14, 2022

Conversation

neuromusic
Copy link
Contributor

Hi Grzegorz

I’m reaching out with this pull request to ask for your help preparing your plugin for a new “Filter by Category” feature we’ll be launching for the napari hub near the end of January.

This PR does 2 things:

  1. adds our proposed labels to .napari/config.yml to help users find your plugin
  2. adds an Action to your repository in .github/workflows/plugin_preview.yml to help you preview changes to your plugin’s napari hub page

What is the “Filter by Category” feature?

We will let users filter plugins on the napari hub by Category, based on your own annotations of your plugin selected fro terms in the EDAM Bioimaging ontology. You are able to specify, in your .napari/config.yml file, any number of EDAM labels at whatever depth of the taxonomy is most appropriate. You can see a mockup of this feature below

prototype of filter dialog letting napari hub users filter plugins based on workflow step

We currently support viewing category metadata on the individual plugin pages, but before we let users filter by category, we want to get categories populated for as many plugins as possible.

For more information, see A plugin developer’s guide to categories on the napari hub.

Can you make adding category labels to my plugin easier?

Totally. We know that learning about the EDAM Bioimaging ontology and adding relevant categories is a lot of work. So we took a first pass for you!

To help you get started, our team has reviewed your plugin’s description and metadata and identified category labels that we feel would be a good fit based on the information you’ve provided so far. These were proposed initially by our Biocuration Team who are experts in annotating scholarly literature with biological concepts, then reviewed by my colleague, @chili-chiu, an Application Scientist on our team.We did our best to select relevant labels, but we might be wrong! Please review and edit these categories to best fit your plugin… and let us know how we did! We’re exploring ways that we might be able to automate suggestions in the future for new plugin developers. We’ll be launching the “Filter by Category” feature on Jan 27, 2022, so if you’d like to take advantage of this new feature, please merge this PR by then!

Can you let me preview the changes before I merge this PR?

Yeah, we can do that… not just for categories, but for all of your metadata!

To make it easier for you to update and maintain your plugin’s metadata, and see immediately how changes to links or your description will affect your napari hub listing, we’ve launched a new service that lets you preview your plugin’s page directly from PRs onto your plugin repository (like this one) and see what metadata you might be missing.

Prototype of the napari hub Preview Page feature, which highlights missing metadata from your Github repository

This service has two parts:

  • A GitHub Action which parses your plugin’s 8000 metadata
  • A GitHub App which provides a link to a preview of the plugin's napari hub page

To use the new Preview Page feature, you simply need to install the Github App by clicking here and configuring it for this repository. Once you do that, make any update to this PR and you will get a comment from the @napari-hub-bot below with a link to your preview page!

For more information, see Setting Up Plugin Page Previews

We hope that these new features are useful to you! Happy to answer any questions here or on our Discussions page.

@Czaki
Copy link
Collaborator
Czaki commented Jan 3, 2022

As DESCRIPTION.md is needed and PartSeg does not contain this file I try to add basic file to this PR but You do not allow tu push maintainert to this branch. Did you prefer to change this, or I should open my PR basic on this one?

@neuromusic
Copy link
Contributor Author

You do not allow tu push maintainert to this branch.

🤔 it looks like you should have access...

image

@Czaki
Copy link
Collaborator
Czaki commented Jan 3, 2022

ok. It was problem with git lfs (I try it old time ago)

@neuromusic
Copy link
Contributor Author

awesome :D

edit and merge as you see fit!

@Czaki
Copy link
Collaborator
Czaki commented Jan 3, 2022

why CITATION.cff is required? Is there any place where all requirements are described?

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@neuromusic
Copy link
Contributor Author

why CITATION.cff is required?

it shouldn't be required... did a "missing" warning pop up? if so, that's a bug and we should prevent that.

Is there any place where all requirements are described?

the only "required" items are the ones that are listed in the checkbox at the top of the preview.... we can get them added
more explicitly to the napari hub wiki

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@neuromusic
Copy link
Contributor Author

@Czaki can you make a small change to re-trigger the build and confirm that chanzuckerberg/napari-hub#381 fixed the issue?

@neuromusic
Copy link
Contributor Author

or you might be able to just re-run the failed action?

@deprecated-napari-hub-preview-bot
8000 Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@Czaki
Copy link
Collaborator
Czaki commented Jan 7, 2022

@neuromusic I just rerun action before adding description and citation and as you could see it pass (the last preview is from this action).

@Czaki
Copy link
Collaborator
Czaki commented Jan 12, 2022

Wideo1:

2022-01-12.14-04-13.mp4

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@Czaki Czaki added this to the 0.13.15 milestone Jan 13, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Jan 13, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.97 ⭐ 0.97 ⭐ 0.00
Method Length 65.60 🙂 65.60 🙂 0.00
Working memory 6.85 🙂 6.85 🙂 0.00
Quality 70.45% 🙂 70.45% 🙂 0.00%
Other metrics Before After Change
Lines 334 328 -6
Changed files Quality Before Quality After Quality Change
package/PartSeg/plugins/napari_widgets/init.py 99.94% ⭐ 99.94% ⭐ 0.00%
package/PartSeg/plugins/napari_widgets/mask_create_widget.py 71.26% 🙂 71.26% 🙂 0.00%
package/tests/test_PartSeg/test_napari_widgets.py 67.79% 🙂 67.79% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/tests/test_PartSeg/test_napari_widgets.py test_profile_preview_dialog 0 ⭐ 292 ⛔ 9 🙂 55.54% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_napari_widgets.py test_extraction_widget 0 ⭐ 245 ⛔ 8 🙂 59.81% 🙂 Try splitting into smaller methods
package/PartSeg/plugins/napari_widgets/mask_create_widget.py MaskCreate.__init__ 0 ⭐ 196 😞 8 🙂 62.98% 🙂 Try splitting into smaller methods
package/PartSeg/plugins/napari_widgets/mask_create_widget.py MaskCreate.create_mask 6 ⭐ 121 😞 8 🙂 64.59% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_napari_widgets.py test_measurement_create 0 ⭐ 146 😞 7 🙂 69.97% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/489

@codecov
Copy link
codecov bot commented Jan 13, 2022

Codecov Report

Merging #489 (fecb4fe) into develop (a4edff1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #489   +/-   ##
========================================
  Coverage    76.89%   76.89%           
========================================
  Files          144      144           
  Lines        18591    18591           
========================================
  Hits         14296    14296           
  Misses        4295     4295           
Impacted Files Coverage Δ
package/PartSeg/plugins/napari_widgets/__init__.py 100.00% <100.00%> (ø)
...rtSeg/plugins/napari_widgets/mask_create_widget.py 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4edff1...fecb4fe. Read the comment docs.

@Czaki Czaki changed the title Add categories and preview page workflow for the napari hub doc: Add categories and preview page workflow for the napari hu 9E88 b Jan 14, 2022
@Czaki Czaki merged commit b042ad9 into 4DNucleome:develop Jan 14, 2022
@Czaki
Copy link
Collaborator
Czaki commented Jan 14, 2022

Thanks for this.

@Czaki
Copy link
Collaborator
Czaki commented Jan 18, 2022

New description (with categories etc) landed on napari hub pages. https://www.napari-hub.org/plugins/PartSeg Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0