8000 refactor: Drop napari bellow 0.4.12 by Czaki · Pull Request #592 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Drop napari bellow 0.4.12 #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2022
Merged

refactor: Drop napari bellow 0.4.12 #592

merged 1 commit into from
Apr 24, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Apr 24, 2022

Drop support for the old version of napari.

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Apr 24, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 2.99 ⭐ 2.93 ⭐ -0.06 👍
Method Length 49.50 ⭐ 49.18 ⭐ -0.32 👍
Working memory 7.32 🙂 7.35 🙂 0.03 👎
Quality 73.63% 🙂 73.57% 🙂 -0.06% 👎
Other metrics Before After Change
Lines 2562 2476 -86
Changed files Quality Before Quality After Quality Change
package/PartSeg/launcher_main.py 60.25% 🙂 60.94% 🙂 0.69% 👍
package/PartSeg/common_backend/init.py 90.45% ⭐ 94.34% ⭐ 3.89% 👍
package/PartSeg/common_backend/base_settings.py 84.87% ⭐ 84.44% ⭐ -0.43% 👎
package/PartSeg/common_gui/advanced_tabs.py 75.93% ⭐ 76.24% ⭐ 0.31% 👍
package/PartSeg/common_gui/napari_image_view.py 67.52% 🙂 67.51% 🙂 -0.01% 👎
package/tests/test_PartSeg/conftest.py 86.09% ⭐ 89.06% ⭐ 2.97% 👍
package/tests/test_PartSeg/test_napari_image_view.py 72.56% 🙂 72.69% 🙂 0.13% 👍
package/tests/test_PartSeg/test_napari_widgets.py 66.91% 🙂 66.85% 🙂 -0.06% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/napari_image_view.py ImageView.component_mark 14 🙂 223 ⛔ 11 😞 41.69% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.__init__ 1 ⭐ 524 ⛔ 14 😞 42.51% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 19 😞 154 😞 11 😞 43.43% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_backend/base_settings.py BaseSettings.load 10 🙂 175 😞 13 😞 45.56% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView._mark_layer 8 ⭐ 186 😞 13 😞 46.47% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Czaki Czaki added this to the 0.14.1 milestone Apr 24, 2022
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/592

@codecov
Copy link
codecov bot commented Apr 24, 2022 •
edited
Loading

Codecov Report

Merging #592 (4cf0ed2) into develop (2c26399) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff            @@
##           develop     #592   +/-   ##
========================================
  Coverage    80.53%   80.54%           
========================================
  Files          143      143           
  Lines        19164    19150   -14     
========================================
- Hits         15434    15424   -10     
+ Misses        3730     3726    -4
Impacted Files Coverage Δ
package/PartSeg/launcher_main.py 0.00% <0.00%> (ø)
package/PartSeg/common_backend/__init__.py 100.00% <100.00%> (ø)
package/PartSeg/common_backend/base_settings.py 95.39% <100.00%> (-0.03%) ⬇️
package/PartSeg/common_gui/advanced_tabs.py 84.96% <100.00%> (+0.25%) ⬆️
package/PartSeg/common_gui/napari_image_view.py 84.61% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c26399...4cf0ed2. Read the comment docs.

@Czaki Czaki merged commit dc52158 into develop Apr 24, 2022
@Czaki Czaki deleted the refactor/drop_napari_0.4_11 branch April 24, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0