8000 fix: Fixes for napari 0.4.13 by Czaki · Pull Request #506 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Fixes for napari 0.4.13 #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 17, 2022
Merged

fix: Fixes for napari 0.4.13 #506

merged 8 commits into from
Jan 17, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Jan 14, 2022

No description provided.

@sourcery-ai sourcery-ai bot mentioned this pull request Jan 14, 2022
Merged
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@codecov
Copy link
codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #506 (54765f4) into develop (62450af) will decrease coverage by 0.06%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #506      +/-   ##
===========================================
- Coverage    76.87%   76.81%   -0.07%     
===========================================
  Files          144      144              
  Lines        18584    18603      +19     
===========================================
+ Hits         14287    14290       +3     
- Misses        4297     4313      +16
Impacted Files Coverage Δ
package/PartSeg/common_gui/napari_image_view.py 84.69% <60.00%> (-0.85%) ⬇️
package/PartSeg/common_gui/colormap_creator.py 83.55% <100.00%> (-0.72%) ⬇️
...tSeg/plugins/napari_widgets/search_label_widget.py 91.52% <100.00%> (ø)
package/PartSegCore/json_hooks.py 97.88% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62450af...54765f4. Read the comment docs.

@Czaki Czaki force-pushed the bugfix/napari_0_4_13 branch from bda8ab5 to d130d2b Compare January 16, 2022 19:59
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

1 similar comment
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@Czaki Czaki marked this pull request as ready for review January 16, 2022 20:48
@Czaki Czaki added this to the 0.13.15 milestone Jan 17, 2022
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Jan 17, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics Before After Change
Complexity 2.96 ⭐ 2.96 ⭐ 0.00
Method Length 65.17 🙂 64.69 🙂 -0.48 👍
Working memory 7.63 🙂 7.63 🙂 0.00
Quality 71.29% 🙂 71.37% 🙂 0.08% 👍
Other metrics Before After Change
Lines 2301 2322 21
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/colormap_creator.py 76.32% ⭐ 76.30% ⭐ -0.02% 👎
package/PartSeg/common_gui/napari_image_view.py 67.13% 🙂 67.38% 🙂 0.25% 👍
package/PartSeg/plugins/napari_widgets/search_label_widget.py 65.52% 🙂 65.52% 🙂 0.00%
package/tests/test_PartSeg/test_colormap_create.py 69.70% 🙂 69.75% 🙂 0.05% 👍
package/tests/test_PartSeg/test_napari_image_view.py 72.84% 🙂 72.56% 🙂 -0.28% 👎
package/tests/test_PartSegCore/test_json_hooks.py 79.99% ⭐ 79.98% ⭐ -0.01% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 24 😞 154 😞 11 😞 40.04% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.component_mark 14 🙂 223 ⛔ 11 😞 41.69% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.__init__ 1 ⭐ 524 ⛔ 14 😞 42.51% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/colormap_creator.py ColormapList.refresh 8 ⭐ 204 😞 13 😞 45.06% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView._mark_layer 8 ⭐ 186 😞 13 😞 46.47% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/506

@Czaki Czaki merged commit 637f9be into develop Jan 17, 2022
@Czaki Czaki deleted the bugfix/napari_0_4_13 branch January 17, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.15
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0