8000 fix: Register PartSeg plugins before start napari widgets. by Czaki · Pull Request #611 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Register PartSeg plugins before start napari widgets. #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2022
Merged

fix: Register PartSeg plugins before start napari widgets. #611

merged 4 commits into from
May 4, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented May 2, 2022

No description provided.

@Czaki Czaki added this to the v0.14.2 milestone May 2, 2022
@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/611

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented May 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.34%.

Quality metrics Before After Change
Complexity 9.26 🙂 10.77 🙂 1.51 👎
Method Length 38.28 ⭐ 40.12 ⭐ 1.84 👎
Working memory 5.82 ⭐ 6.39 🙂 0.57 👎
Quality 67.65% 🙂 65.31% 🙂 -2.34% 👎
Other metrics Before After Change
Lines 263 272 9
Changed files Quality Before Quality After Quality Change
package/PartSeg/plugins/init.py 84.67% ⭐ 84.62% ⭐ -0.05% 👎
package/PartSeg/plugins/itk_snap_save/init.py 95.68% ⭐ 95.68% ⭐ 0.00%
package/PartSeg/plugins/napari_widgets/init.py 99.95% ⭐ 99.64% ⭐ -0.31% 👎
package/PartSegCore/_old_json_hooks.py 55.83% 🙂 51.26% 🙂 -4.57% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/_old_json_hooks.py profile_hook 25 😞 316 ⛔ 9 🙂 33.61% 😞 Refactor to reduce nesting. Try splitting into smaller methods
package/PartSegCore/_old_json_hooks.py part_hook 9 🙂 139 😞 7 🙂 61.95% 🙂 Try splitting into smaller methods
package/PartSeg/plugins/init.py register_napari_plugins 1 ⭐ 35 ⭐ 10 😞 77.92% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor
< 8000 p dir="auto">The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/611

@codecov
Copy link
codecov bot commented May 4, 2022

Codecov Report

Merging #611 (d11a22e) into develop (e2daa4c) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##           develop     #611      +/-   ##
===========================================
- Coverage    81.10%   81.08%   -0.02%     
===========================================
  Files          143      143              
  Lines        19140    19148       +8     
===========================================
+ Hits         15524    15527       +3     
- Misses        3616     3621       +5
Impacted Files Coverage Δ
package/PartSeg/plugins/itk_snap_save/__init__.py 91.66% <0.00%> (ø)
package/PartSeg/plugins/__init__.py 71.42% <100.00%> (ø)
package/PartSeg/plugins/napari_widgets/__init__.py 100.00% <100.00%> (ø)
package/PartSegCore/_old_json_hooks.py 59.25% <100.00%> (-3.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2daa4c...d11a22e. Read the comment docs.

@Czaki Czaki merged commit 03d9c1f into develop May 4, 2022
@Czaki Czaki deleted the feature/load_plugins_in_napari_widgets branch May 5, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.2
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0