8000 fix: Wrong error report whe no component is found in restatrtable segmentation algorithm. by Czaki · Pull Request #633 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Wrong error report whe no component is found in restatrtable segmentation algorithm. #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2022
Merged

fix: Wrong error report whe no component is found in restatrtable segmentation algorithm. #633

merged 2 commits into from
May 21, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented May 21, 2022

No description provided.

@Czaki Czaki added this to the v0.14.3 milestone May 21, 2022
@deprecated-napari-hub-preview-bot
Copy link
deprecated-napari-hub-preview-bot bot commented May 21, 2022 •
edited
Loading

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/633
Updated: 2022-05-21T20:19:34.502800

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented May 21, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.78%.

Quality metrics Before After Change
Complexity 6.22 ⭐ 6.41 ⭐ 0.19 👎
Method Length 39.03 ⭐ 38.62 ⭐ -0.41 👍
Working memory 8.71 🙂 8.18 🙂 -0.53 👍
Quality 68.74% 🙂 69.52% 🙂 0.78% 👍
Other metrics Before After Change
Lines 495 499 4
Changed files Quality Before Quality After Quality Change
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py 68.74% 🙂 69.52% 🙂 0.78% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py ThresholdBaseAlgorithm.calculation_run 24 😞 324 ⛔ 12 😞 28.31% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py BaseMultiScaleOpening.calculation_run 15 🙂 316 ⛔ 15 😞 30.78% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py BaseThresholdFlowAlgorithm.calculation_run 8 ⭐ 203 😞 20 ⛔ 38.05% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py OtsuSegment.calculation_run 7 ⭐ 183 😞 9 🙂 54.93% 🙂 Try splitting into smaller methods
package/PartSegCore/segmentation/restartable_segmentation_algorithms.py BaseMultiScaleOpening.get_info_text 0 ⭐ 53 ⭐ 12 😞 72.38% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link
codecov bot commented May 21, 2022

Codecov Report

Merging #633 (f373136) into develop (1453051) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop     #633      +/-   ##
===========================================
- Coverage    82.91%   82.91%   -0.01%     
===========================================
  Files          143      143              
  Lines        19125    19129       +4     
===========================================
+ Hits         15858    15861       +3     
- Misses        3267     3268       +1
Impacted Files Coverage Δ
...egmentation/restartable_segmentation_algorithms.py 96.28% <87.50%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1453051...f373136. Read the comment docs.

@Czaki Czaki merged commit c79f1f3 into develop May 21, 2022
@Czaki Czaki deleted the bugfxi/lack_of_components_error branch May 21, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.3
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0