8000 feat: Add option for multiline field in algorithm parameters by Czaki · Pull Request #766 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add option for multiline field in algorithm parameters #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 6, 2022
Merged

feat: Add option for multiline field in algorithm parameters #766

merged 11 commits into from
Nov 6, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Oct 21, 2022

In this PR there is implemented support for multiline dynamic fields in algorithms parameters.

The motivation is to allow dynamic adjust parameters of files loaded from external resources (for example deep learning model).

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Oct 21, 2022 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 1.56 ⭐ 1.61 ⭐ 0.05 👎
Method Length 67.24 🙂 66.62 🙂 -0.62 👍
Working memory 5.67 ⭐ 5.65 ⭐ -0.02 👍
Quality 76.15% ⭐ 76.29% ⭐ 0.14% 👍
Other metrics Before After Change
Lines 2606 2655 49
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/algorithms_description.py 75.88% ⭐ 75.65% ⭐ -0.23% 👎
package/PartSeg/common_gui/universal_gui_part.py 76.79% ⭐ 77.23% ⭐ 0.44% 👍
package/PartSegCore/segmentation/algorithm_base.py 81.23% ⭐ 81.07% ⭐ -0.16% 👎
package/tests/test_PartSeg/test_common_gui.py 75.59% ⭐ 75.91% ⭐ 0.32% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/algorithms_description.py FormWidget._add_to_layout 15 🙂 275 ⛔ 12 😞 36.44% 😞 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_gui.py TestMultipleFileWidget.test_load_files 1 ⭐ 272 ⛔ 12 😞 49.63% 😞 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_gui.py test_p_load_dialog 1 ⭐ 335 ⛔ 9 🙂 53.28% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_gui.py TestMultipleFileWidget.test_load_recent 1 ⭐ 229 ⛔ 11 😞 53.55% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/segmentation/algorithm_base.py ROIExtractionAlgorithm.__repr__ 3 ⭐ 126 😞 16 ⛔ 53.66% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link
deprecated-napari-hub-preview-bot bot commented Oct 21, 2022 •
edited
Loading

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/766
Updated: 2022-11-06T17:33:30.899297

@Czaki Czaki added this to the v0.14.5 milestone Oct 26, 2022
@Czaki Czaki force-pushed the feature/allow_multiline_widget branch from 4247ccd to eebe982 Compare October 26, 2022 10:59
@Czaki Czaki force-pushed the feature/allow_multiline_widget branch from eebe982 to 6112e7a Compare November 3, 2022 00:14
@codecov
Copy link
codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Base: 89.70% // Head: 89.73% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d76600a) compared to base (d783ed9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #766      +/-   ##
===========================================
+ Coverage    89.70%   89.73%   +0.02%     
===========================================
  Files          192      193       +1     
  Lines        29725    29922     +197     
===========================================
+ Hits         26666    26851     +185     
- Misses        3059     3071      +12
< 8000 td>package/PartSegCore/segmentation/algorithm_base.py
Impacted Files Coverage Δ
92.25% <ø> (ø)
...ckage/PartSeg/common_gui/algorithms_description.py 94.91% <100.00%> (+0.03%) ⬆️
package/PartSeg/common_gui/universal_gui_part.py 79.80% <100.00%> (+0.82%) ⬆️
package/tests/test_PartSeg/test_common_gui.py 99.84% <100.00%> (+<0.01%) ⬆️
package/tests/conftest.py 92.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 4b836c1 into develop Nov 6, 2022
@Czaki Czaki deleted the feature/allow_multiline_widget branch November 6, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.5
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0