8000 style: Change default theme to dark, remove blinking windows on startup. by Czaki · Pull Request #809 · 4DNucleome/PartSeg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

style: Change default theme to dark, remove blinking windows on startup. #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 28, 2022
Merged

style: Change default theme to dark, remove blinking windows on startup. #809

merged 6 commits into from
Nov 28, 2022

Conversation

Czaki
Copy link
Collaborator
@Czaki Czaki commented Nov 27, 2022

No description provided.

@Czaki Czaki added this to the 0.15.0 milestone Nov 27, 2022
@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Nov 27, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.07%.

Quality metrics Before After Change
Complexity 2.48 ⭐ 2.49 ⭐ 0.01 👎
Method Length 62.19 🙂 62.37 🙂 0.18 👎
Working memory 6.17 ⭐ 6.19 ⭐ 0.02 👎
Quality 73.18% 🙂 73.11% 🙂 -0.07% 👎
Other metrics Before After Change
Lines 3017 3018 1
Changed files Quality Before Quality After Quality Change
package/PartSeg/_roi_analysis/main_window.py 61.65% 🙂 61.65% 🙂 0.00%
package/PartSeg/common_backend/base_settings.py 83.27% ⭐ 83.27% ⭐ 0.00%
package/PartSeg/common_gui/algorithms_description.py 75.63% ⭐ 75.33% ⭐ -0.30% 👎
package/PartSeg/common_gui/stacked_widget_with_selector.py 94.17% ⭐ 94.13% ⭐ -0.04% 👎
package/PartSeg/plugins/napari_widgets/roi_extraction_algorithms.py 69.99% 🙂 69.94% 🙂 -0.05% 👎
package/tests/test_PartSeg/test_common_backend.py 73.41% 🙂 73.41% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/algorithms_description.py FormWidget._add_to_layout 15 🙂 275 ⛔ 12 😞 36.44% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/plugins/napari_widgets/roi_extraction_algorithms.py ROIExtractionAlgorithms.set_result 13 🙂 270 ⛔ 12 😞 38.33% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py Options.__init__ 0 ⭐ 613 ⛔ 18 ⛔ 39.04% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py MainWindow.__init__ 2 ⭐ 851 ⛔ 14 😞 41.14% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py Options.save_pipeline 11 🙂 229 ⛔ 11 😞 43.93% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link
deprecated-napari-hub-preview-bot bot commented Nov 27, 2022 •
edited
Loading

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/809
Updated: 2022-11-28T01:25:59.403832

@codecov
Copy link
codecov bot commented Nov 27, 2022 •
edited
Loading

Codecov Report

Base: 89.83% // Head: 89.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9b1232c) compared to base (ff4319a).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #809      +/-   ##
===========================================
- Coverage    89.83%   89.83%   -0.01%     
===========================================
  Files          194      194              
  Lines        30038    30034       -4     
===========================================
- Hits         26984    26980       -4     
  Misses        3054     3054
Impacted Files Coverage Δ
package/PartSeg/_roi_analysis/main_window.py 72.49% <0.00%> (ø)
...PartSeg/common_gui/stacked_widget_with_selector.py 63.63% <0.00%> (ø)
...ckage/PartSeg/common_gui/algorithms_description.py 94.92% <87.50%> (-0.02%) ⬇️
package/PartSeg/common_backend/base_settings.py 96.63% <100.00%> (ø)
...lugins/napari_widgets/roi_extraction_algorithms.py 93.09% <100.00%> (-0.05%) ⬇️
package/tests/test_PartSeg/test_common_backend.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki changed the title Change default theme to dark Change default theme to dark, remove blinking windows on startup. Nov 28, 2022
@Czaki Czaki changed the title Change default theme to dark, remove blinking windows on startup. style: Change default theme to dark, remove blinking windows on startup. Nov 28, 2022
@Czaki Czaki merged commit 2ccb744 into develop Nov 28, 2022
@Czaki Czaki deleted the update_style branch November 28, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Czaki
0