Fix completion, code formatting, and hover help for dartls #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart LSP insists on getting the invocation kind for completions, and on the diagnostics for the "Format" code action to be empty, but _not_ `null`. Dart's LS sends hover help responses as the deprecated protocol.MarkedString instead of protocol.MarkupContent. This requires [a tweak to the generated LSP protocol code](9fans/go-lsp-internal#4) as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart LSP insists on getting the invocation kind for completions, and on the diagnostics for the "Format" code action to be empty, but not
null.Dart's LS sends hover help responses as the deprecated protocol.MarkedString instead of protocol.MarkupContent.
This requires a tweak to the generated LSP protocol code as well, so it should probably be merged after the generated code has been updated and the
replaceoverride ingo.modhas been removed.