MML #44: Mek jump boosters and jump jets #6347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6347 +/- ##
============================================
+ Coverage 10.87% 11.32% +0.44%
- Complexity 6266 6270 +4
============================================
Files 1066 1070 +4
Lines 141127 135927 -5200
Branches 21049 21012 -37
============================================
+ Hits 15352 15387 +35
+ Misses 124226 118999 -5227
+ Partials 1549 1541 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 23, 2025
IllianiBird
added a commit
to MegaMek/megamek
that referenced
this pull request
Mar 23, 2025
This is the MM part of allowing both jump jets and Mek mechanical jump boosters. - When a unit has only MMJB, movement behaves as before - When a unit has both JJ and MMJB and the player selects jumping, they'll have to choose between the systems - In the code, the various versions of getJumpMP() now only address jump jets. For MMJB, separate methods are used. If only a general jump value of any sort is needed, e.g. for scenario generation, a new method getAnyTypeMaxJumpMP() can be used. The two have the same result on anything unit but Meks when MMJB are involved. Requires MegaMek/megameklab#1780 and MegaMek/mekhq#6347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MHQ part of allowing both jump jets and Mek mechanical jump boosters. It only has a few small adaptations.
Requires MegaMek/megamek#6752 and MegaMek/megameklab#1780