Updated Insufficient Medics Nag To Use Immersive Dialog #6389
Conversation
- Refactored `InsufficientMedicsNagDialog` to utilize `ImmersiveDialogSimple` for improved modularity and customization. - Replaced inheritance from `AbstractMHQNagDialog` with a standalone class to simplify and streamline the implementation. - Updated NagController logic to replace `wasAdvanceDayCanceled()` with `shouldCancelAdvanceDay()` to reflect the updated behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6389 +/- ##
============================================
- Coverage 11.31% 11.30% -0.02%
+ Complexity 6285 6280 -5
============================================
Files 1070 1070
Lines 136146 136184 +38
Branches 21029 21034 +5
============================================
- Hits 15407 15390 -17
- Misses 119192 119253 +61
+ Partials 1547 1541 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Looks good to me.
I this feels like an opportunity to extract a middle-level class, say something like an ImmersiveNagDialog, with a similar layout but more parameterization.
Nothing that needs doing now, just something to think about if more immersive nag dialogs are needed.
|
Yeah, I concur. It's something that will almost certainly be added once I spot a good use-case. I need that so I can tell what functionality is required. As things stand |
InsufficientMedicsNagDialogto utilizeImmersiveDialogSimplefor improved modularity and customization.AbstractMHQNagDialogwith a standalone class to simplify and streamline the implementation.wasAdvanceDayCanceled()withshouldCancelAdvanceDay()to reflect the updated behavior.