8000 Fixed Error in Retirement Defection Checker if 'Use Commander Leadership Only' is Selected But No Campaign Commander Has Been Chosen by IllianiBird · Pull Request #6392 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Error in Retirement Defection Checker if 'Use Commander Leadership Only' is Selected But No Campaign Commander Has Been Chosen #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Fixed Error in Retirement Defection Checker if 'Use Commander Leadership Only' is Selected But No Campaign Commander Has Been Chosen #6392

merged 1 commit into from
Mar 25, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Added a null check for flaggedCommander to prevent potential null pointer exceptions.

Fix #6391

@IllianiBird
Fixed Error in Retirement Defection Checker if 'Use Commander Leaders…
79a165d 
…hip Only' is Selected But No Campaign Commander Has Been Chosen

- Added a null check for `flaggedCommander` to prevent potential null pointer exceptions.
@IllianiBird IllianiBird added Bug Personnel Personnel-related Issues Severity: Medium Issues described as medium severity as per the new issue form labels Mar 24, 2025
@IllianiBird IllianiBird self-assigned this Mar 24, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.30%. Comparing base (a10ed19) to head (79a165d).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6392      +/-   ##
============================================
- Coverage     11.31%   11.30%   -0.02%     
+ Complexity     6285     6282       -3     
============================================
  Files          1070     1070              
  Lines        136146   136166      +20     
  Branches      21029    21035       +6     
============================================
- Hits          15407    15395      -12     
- Misses       119192   119225      +33     
+ Partials       1547     1546       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Still getting used to some of the new formatting defaults.

@IllianiBird
Copy link
Collaborator Author

Sorry, Sleet. I should have flagged the line the change occurred on. My mind was elsewhere.

@IllianiBird IllianiBird merged commit a748819 into MegaMek:master Mar 25, 2025
6 checks passed
@IllianiBird IllianiBird deleted the commanderErrorRetirement branch March 25, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug Personnel Personnel-related Issues Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Prisoner-related NPE when concluding contract/mission without StratCon
2 participants
@IllianiBird @Sleet01
0