Refactored Untreated Personnel Nag Dialog To Use Immersive Dialog Framework #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework - Replaced `AbstractMHQNagDialog` with `ImmersiveDialogNag` for the `UntreatedPersonnelNagDialog` class. - Updated dialog initialization logic to use constants and methods from `ImmersiveDialogNag`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6414 +/- ##
=========================================
Coverage 11.29% 11.30%
- Complexity 6280 6288 +8
=========================================
Files 1071 1071
Lines 136139 136158 +19
Branches 21057 21064 +7
=========================================
+ Hits 15373 15388 +15
- Misses 119229 119233 +4
Partials 1537 1537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/resources/mekhq/resources/NagDialogs.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractMHQNagDialogwithImmersiveDialogNagfor theUntreatedPersonnelNagDialogclass.ImmersiveDialogNag.Requirements
Requires #6401