Updated Overdue Loan Payment Nag to Use Immersive Dialog #6421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved overdue loan handling in `CampaignGUI` with immersive dialog messages for both in-character and out-of-character contexts. - Declared 'checkOverDueLoans' (in `Campaign.java`) deprecated and marked for removal.
IllianiBird
commented
Mar 25, 2025
| dialogOverdueLoans.title=Overdue loans | ||
| dialogOverdueLoans.text=You must resolve overdue loans before advancing the day. | ||
|
|
||
| # New Day Blockers |
There was a problem hiding this comment.
New resource keys
IllianiBird
commented
Mar 25, 2025
| @@ -8970,14 +8937,15 @@ public void shutdownAtB() { | |||
| atbEventProcessor.shutdown(); | |||
| } | |||
|
|
|||
| @Deprecated(forRemoval = true, since = "0.50.05") | |||
There was a problem hiding this comment.
Deprecated method
IllianiBird
commented
Mar 25, 2025
| * Checks if there are any overdue loans If the {@code checkOverDueLoans()} method of the {@link Campaign} | ||
| * associated with the given {@link DayEndingEvent} returns {@code true}, the funds get refreshed, a dialog shows up | ||
| * informing the user of the overdue loans, and the {@link DayEndingEvent} is canceled. | ||
| * Checks for overdue loan payments in the campaign and handles them by displaying a warning dialog and canceling |
There was a problem hiding this comment.
Updated method
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6421 +/- ##
============================================
- Coverage 11.29% 11.28% -0.01%
+ Complexity 6291 6285 -6
============================================
Files 1072 1072
Lines 136567 136601 +34
Branches 21119 21122 +3
============================================
- Hits 15430 15421 -9
- Misses 119592 119637 +45
+ Partials 1545 1543 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # MekHQ/resources/mekhq/resources/CampaignGUI.properties # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/gui/CampaignGUI.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CampaignGUIwith immersive dialog messages for both in-character and out-of-character contexts.Campaign.java) deprecated and marked for removal.Order of Merging
Must be merged AFTER #6420
Reviewer Note
There are a lot of automatic format changes in this PR, I've commented the functional changes. There rest is chaff and can probably be ignored.
Dev Notes
This also fixes a bug where the user could bypass the New Day blocker just by clicking the 'x' in the dialog.
I haven't updated the 'scenarios due' nag, as that's only relevant to campaigns using the deprecated Legacy AtB digital GM.