Removed the Ability for Ignored StratCon Scenarios to 'Wander' if Friendly Facility is Present #6423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endly Facility is Present
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6423 +/- ##
=========================================
Coverage 11.28% 11.29%
- Complexity 6285 6289 +4
=========================================
Files 1072 1072
Lines 136601 136587 -14
Branches 21122 21114 -8
=========================================
+ Hits 15421 15432 +11
+ Misses 119637 119613 -24
+ Partials 1543 1542 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
commented
Mar 25, 2025
| @@ -4473,30 +4445,22 @@ private void processNewDayATBScenarios() { | |||
| return; | |||
| } | |||
|
|
|||
| final boolean stub = StratconRulesManager.processIgnoredScenario((AtBDynamicScenario) scenario, | |||
| campaignState); | |||
| processIgnoredScenario(scenario.getId(), campaignState); | |||
There was a problem hiding this comment.
This is where we updated ignored scenario handling in Campaign.java
IllianiBird
commented
Mar 25, 2025
| .map(track -> processIgnoredScenario(track.getBackingScenariosMap().get(scenario.getId()), | ||
| campaignState)) | ||
| .orElse(true); | ||
| public static void processIgnoredScenario(int scenarioId, StratconCampaignState campaignState) { |
There was a problem hiding this comment.
Updated method. Mostly moving it from a stream to a traditional loop. We gain nothing from using a Stream here.
IllianiBird
commented
Mar 25, 2025
| } | ||
|
|
||
| /** | ||
| * Processes an ignored Stratcon scenario | ||
| * Processes an ignored StratCon scenario by removing it from the campaign state and updating related state |
There was a problem hiding this comment.
This method contains the main changes made by this PR
IllianiBird
commented
Mar 25, 2025
| @@ -337,6 +340,19 @@ public boolean isTurningPoint() { | |||
| return turningPoint; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Added new utility method
- Renamed `processIgnoredScenario` to `processIgnoredDynamicScenario` for ID-based processing. - Renamed `processIgnoredScenario` (overloaded version) to `processIgnoredStratConScenario` for object-based processing.
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of Merging
Must be merged BEFORE #6423
Reviewer Note
There are a lot of automatic format changes in this PR, I've commented the functional changes. There rest is chaff and can probably be ignored.
Dev Notes
The ability for scenarios to 'wander' towards allied facilities was pretty cool, but it doesn't mesh well with the 'Refuse the Engagement' approach introduced earlier in the year. Where players are given greater strategic control over what scenarios they fight.
The wandering effect resulted in players potentially getting slammed with consecutive CVP losses without knowing why - unless they already knew. The solution was to deploy a force to the scenario and then refuse the engagement - at which point the scenario would be removed. This was hard for users to grasp and was a pretty awkward interaction.
Wandering scenarios are more suited to a 'persistent opfor' style of play that is not currently represented in StratCon.