Updated Scenario and Deployment Labels in StratCon #6447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated text rendering logic to use bold uppercase text and adjusted rectangle dimensions dynamically based on text. - Simplified redundant `Map` access by replacing `containsKey` with `getOrDefault`. - Replaced hardcoded color and font settings with consistent use of constants.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6447 +/- ##
=========================================
Coverage 11.29% 11.29%
- Complexity 6287 6290 +3
=========================================
Files 1072 1072
Lines 136591 136522 -69
Branches 21118 21106 -12
=========================================
- Hits 15427 15426 -1
+ Misses 119620 119556 -64
+ Partials 1544 1540 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 28, 2025
# Conflicts: # MekHQ/src/mekhq/gui/StratconPanel.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapaccess by replacingcontainsKeywithgetOrDefault.Dev Notes
The goal here is to try and make individual scenarios a little easier for the user to identify without needing to jump back and forth as much between the AoO tab and the Briefing Room. I also wanted to make the labels a little easier on the eyes, as regular red font on gray was (for me, at least) a tad hard to read.