Added Error Handling to Scenario Resolution in PostScenarioDialogHandler
#6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler` - Added a try-catch block around `MekHQ.triggerEvent` to handle exceptions during scenario resolution. - Introduced logging using `MMLogger` to capture detailed error messages and stack traces. - Added an error dialog to inform the user of critical issues and prompt them to report the problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6442 +/- ##
=========================================
Coverage 11.28% 11.28%
- Complexity 6282 6287 +5
=========================================
Files 1072 1072
Lines 136363 136372 +9
Branches 21089 21088 -1
=========================================
+ Hits 15383 15394 +11
+ Misses 119445 119439 -6
- Partials 1535 1539 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MekHQ.triggerEventto handle exceptions during scenario resolution.MMLoggerto capture detailed error messages and stack traces.A part of the investigation into Sentry report: https://sentry.tapenvy.us/organizations/tapenvyus/issues/4078/?alert_rule_id=13&alert_type=issue¬ification_uuid=17ad74c9-582d-4287-8a72-ea9e897dca1e&project=10&referrer=discord