8000 Fixed Infirmary Assign/Unassign Interactions by IllianiBird · Pull Request #6443 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Infirmary Assign/Unassign Interactions #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Moved JScrollPane initialization directly after related JList setup to improve initialization flow.
  • Fixed Assign/Unassign issues and other weirdness.

Fix #6380

Dev Notes

Just a classic case of me butchering some merge conflicts. Nothing too exciting.

- Moved JScrollPane initialization directly after related JList setup to improve initialization flow.
- Fixed Assign/Unassign issues and other weirdness.
@IllianiBird IllianiBird added Bug GUI Severity: Medium Issues described as medium severity as per the new issue form labels Mar 26, 2025
@IllianiBird IllianiBird self-assigned this Mar 26, 2025
Copy link
codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.27%. Comparing base (7ba01b2) to head (afcb84b).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6443      +/-   ##
============================================
- Coverage     11.28%   11.27%   -0.02%     
+ Complexity     6287     6281       -6     
============================================
  Files          1072     1072              
  Lines        136372   136356      -16     
  Branches      21088    21088              
============================================
- Hits          15394    15376      -18     
- Misses       119439   119444       +5     
+ Partials       1539     1536       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird changed the title Fixed Interactions Fixed Infirmary Assign/Unassign Interactions Mar 26, 2025
@IllianiBird IllianiBird merged commit 589b7bc into MegaMek:master Mar 28, 2025
6 checks passed
@IllianiBird IllianiBird deleted the infirmaryFix branch March 31, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.50.05-SNAPSHOT] Can no longer manually assign/unassigned injured in infirmary, automatic optimise works fine.
2 participants
0