Company Generator & Contract Market Now Trigger On New Campaign; Adjusted StratCon Promo Trigger #6452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sted StratCon Promo Trigger - Introduced `triggerStartUpDialogs` method to streamline and sequence startup dialogs. - Displays StratCon notice, if enabled. - Launches Company Generation Dialog for initial company setup. - Opens Contract Market Dialog when contract market method is active. - Updated `showStratConNotice` method to no longer rely on date for trigger.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6452 +/- ##
============================================
- Coverage 11.28% 11.27% -0.01%
+ Complexity 6284 6281 -3
============================================
Files 1072 1072
Lines 136384 136375 -9
Branches 21090 21090
============================================
- Hits 15389 15380 -9
+ Misses 119460 119459 -1
- Partials 1535 1536 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggerStartUpDialogsmethod to streamline and sequence startup dialogs.showStratConNoticemethod to no longer rely on date for trigger.Dev Notes
In short, when a player starts a new campaign, following setting up campaign options they will automatically be presented with the StratCon Promo dialog (if appropriate), then the Company Generator dialog, finally the Contract Market (if contract market isn't disabled).
It's my hope this will significantly streamline the new campaign process, while also making things easier on new users.