Increased the Number of Contracts Generated for New Campaigns #6453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added logic to enhance contract generation during new campaigns: - Temporarily boosted unit rating to provide more contract opportunities at the start of a campaign. - Increased the number of initial contracts to ensure players can immediately participate in gameplay.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6453 +/- ##
============================================
- Coverage 11.30% 11.29% -0.01%
+ Complexity 6289 6286 -3
============================================
Files 1072 1072
Lines 136541 136551 +10
Branches 21116 21121 +5
============================================
- Hits 15433 15427 -6
- Misses 119564 119579 +15
- Partials 1544 1545 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 28, 2025
# Conflicts: # MekHQ/src/mekhq/campaign/market/contractMarket/AtbMonthlyContractMarket.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Notes
We've had plenty of user feedback at this point that the initial contracts are generally a little stingy. This has resulted in a tendency for players to spam 'Generate Contract (GM)' until they get something they like the look of. While there is nothing wrong with that, I feel like we can do better.
Previously, new campaigns would generate
1d6 - 4 + unitRatingModcontracts. However, during campaign creation the player doesn't have a unit rating modifier meaning the equation is actually1d6 - 4, or 0-2. Now, there is a conditional that ensures no fewer than 2 contracts generation (under normal circumstances), but that's still pretty miserly.Now we temporarily give the player a unit rating modifier of REGULAR (or +3) and we change the calculation to be
1d6 + (unitRatingMod * 2)or1d6 + 6(for new campaigns only). This ensures new campaigns are always presented with 7-12 contracts.It's my hope that this will wean players off of spamming 'generate contract', encouraging them to pick up contracts that might not be perfect, but where those imperfections push an emergent narrative. It also improves our new user experience, as new users generally didn't know about the option of generating contracts in GM mode.