Added Helper Methods to PersonnelTableMouseAdapter for Cleaner Campaign Access
#6472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpaign` Access - Introduced helper methods `getCampaign()` and `getCampaignOptions()` to streamline campaign data access. - Replaced multiple instances of `gui.getCampaign()` and `gui.getCampaign().getCampaignOptions()` with new helper methods for improved readability and maintainability. - Updated references throughout the various command cases to use the new helper methods consistently.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6472 +/- ##
============================================
- Coverage 11.28% 11.27% -0.01%
Complexity 6284 6284
============================================
Files 1072 1072
Lines 136404 136571 +167
Branches 21094 21107 +13
============================================
+ Hits 15391 15403 +12
- Misses 119477 119630 +153
- Partials 1536 1538 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 28, 2025
# Conflicts: # MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java
…the main application frame within `PersonnelTableMouseAdapter`. - Replaced all direct calls to `gui.getFrame()` with the new `getFrame` method for consistency and maintainability.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCampaign()andgetCampaignOptions()to streamline campaign data access.gui.getCampaign()andgui.getCampaign().getCampaignOptions()with new helper methods for improved readability and maintainability.Dev Notes
This PR replaces 164 instances of
gui.getCampaign()with thegetCampaign()helper.And 45 instances of
gui.getCampaign().getCampaignOptions()with thegetCampaignOptions()helper.