Added Optional Autosave at Mission/Contract End #6473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated autosave implementation to replace `requestBeforeMissionAutosave` with `requestBeforeScenarioAutosave` for more accurate naming. - Added support for autosaving before mission/contract conclusion via the new method `requestBeforeMissionEndAutosave` in `IAutosaveService`. - Deprecated `SAVE_BEFORE_MISSIONS_KEY` and replaced it with `SAVE_BEFORE_SCENARIOS_KEY` in `MHQConstants`. - Introduced relevant GUI adjustments for new autosave features, including updated labels in `GUI.properties`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6473 +/- ##
============================================
+ Coverage 11.28% 11.30% +0.01%
- Complexity 6287 6288 +1
============================================
Files 1072 1072
Lines 136372 136326 -46
Branches 21088 21090 +2
============================================
+ Hits 15394 15405 +11
+ Misses 119439 119386 -53
+ Partials 1539 1535 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestBeforeMissionAutosavewithrequestBeforeScenarioAutosavefor more accurate naming.requestBeforeMissionEndAutosaveinIAutosaveService.SAVE_BEFORE_MISSIONS_KEYand replaced it withSAVE_BEFORE_SCENARIOS_KEYinMHQConstants.GUI.properties.Fix #4506