8000 Updated `RepairTab` to Improve Handling of `null` States in `getSelectedTech` by IllianiBird · Pull Request #6488 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated RepairTab to Improve Handling of null States in getSelectedTech #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Added @Nullable annotation to indicate the method can return null.
  • Replaced assertions with proper null checks for techTable and techsModel.
  • Logged errors for uninitialized techTable and techsModel to improve debugging.
  • Ensured the method gracefully handles cases where no row is selected.

…tedTech`

- Added `@Nullable` annotation to indicate the method can return null.
- Replaced assertions with proper null checks for `techTable` and `techsModel`.
- Logged errors for uninitialized `techTable` and `techsModel` to improve debugging.
- Ensured the method gracefully handles cases where no row is selected.
Copy link
codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.29%. Comparing base (29f4717) to head (60d3cd7).
Report is 97 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6488      +/-   ##
============================================
- Coverage     11.29%   11.29%   -0.01%     
+ Complexity     6288     6285       -3     
============================================
  Files          1072     1072              
  Lines        136563   136571       +8     
  Branches      21121    21119       -2     
============================================
- Hits          15425    15419       -6     
- Misses       119594   119612      +18     
+ Partials       1544     1540       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit 9871b5a into MegaMek:master Mar 31, 2025
6 checks passed
@IllianiBird IllianiBird deleted the nullableTableRepairTab branch March 31, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0