Fixed Minimum Bid Calculation in Mercenary Auction #6500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected the minimum bid logic by removing its dependency on support points, ensuring it now scales accurately with the required combat teams. - Adjusted the final bid computation to account for the updated minimum bid calculation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6500 +/- ##
============================================
- Coverage 11.29% 11.29% -0.01%
+ Complexity 6291 6284 -7
============================================
Files 1072 1072
Lines 136567 136567
Branches 21119 21119
============================================
- Hits 15430 15419 -11
- Misses 119592 119604 +12
+ Partials 1545 1544 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Notes
Marking this as 'high' as it prevented use of this system.