Fixed Skill Deprecator Refund & Refund All Options #6502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new dialog option to handle individual skill refunds during deprecation. - Updated `SkillDeprecationTool` to include `REFUND_DIALOG_OPTION_INDEX` for the new refund option. - Modified `CampaignXmlParser` to properly handle the `refundAllDeprecatedSkills` flag. - Ensured functionality for both individual and "refund all" options in skill deprecation workflows.
# Conflicts: # MekHQ/src/mekhq/campaign/personnel/SkillDeprecationTool.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6502 +/- ##
============================================
- Coverage 11.24% 11.24% -0.01%
+ Complexity 6296 6293 -3
============================================
Files 1079 1079
Lines 137389 137393 +4
Branches 21262 21263 +1
============================================
- Hits 15455 15450 -5
- Misses 120387 120395 +8
- Partials 1547 1548 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkillDeprecationToolto includeREFUND_DIALOG_OPTION_INDEXfor the new refund option.CampaignXmlParserto properly handle therefundAllDeprecatedSkillsflag.Requirements
Requires #6493 && #6494
Dev Notes
Skills were only refunding if the user clicked 'Refund All' and only if the user clicked 'Refund All' for all characters.