8000 Parts Fixes Grab Bag by IllianiBird · Pull Request #6514 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parts Fixes Grab Bag #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Parts Fixes Grab Bag #6514

merged 1 commit into from
Apr 1, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Retired a number of uses of the deprecated addPart with its' replacement, also called addPart
  • Added GM ability to reduce items in Warehouse by n rather than just 'remove all'
  • Added GM ability to toggle the 'newness' of an item in the Warehouse
  • Fixed 'change quality' GM ability in the Warehouse to no longer throw an error if canceled.

Fix #2368

@IllianiBird
Parts Fixes Grab Bag
40708ed 
- Retired a number of uses of the deprecated `addPart` with its' replacement, also called `addPart`
- Added GM ability to reduce items in Warehouse by `n` rather than just 'remove all'
- Added GM ability to toggle the 'newness' of an item in the Warehouse
- Fixed 'change quality' GM ability in the Warehouse to no longer throw an error if canceled.
@IllianiBird IllianiBird added Bug Parts/Repair/Refit GUI UX User experience Severity: Low Issues described as low severity as per the new issue form labels Mar 31, 2025
@IllianiBird IllianiBird self-assigned this Mar 31, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.24%. Comparing base (860c0df) to head (40708ed).
Report is 27 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6514      +/-   ##
============================================
- Coverage     11.24%   11.24%   -0.01%     
+ Complexity     6299     6291       -8     
============================================
  Files          1079     1079              
  Lines        137379   137407      +28     
  Branches      21259    21270      +11     
============================================
- Hits          15452    15445       -7     
- Misses       120384   120420      +36     
+ Partials       1543     1542       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit e9fb81f into MegaMek:master Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IllianiBird IllianiBird

Labels
Bug GUI Parts/Repair/Refit Severity: Low Issues described as low severity as per the new issue form UX User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE - GM Mode option to remove # of parts
1 participant
@IllianiBird
0