Prisoners will No Longer Be Executed when Security is Told to 'Free' Them #6521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Them. - Added a `boolean isExecution` parameter to `processPrisonerResolutionCommand` to handle execution-specific logic. - Updated all call sites to pass the appropriate flag for execution-related commands. - Deprecated the old `processPrisonerResolutionCommand` method in favor of the new one, marking it for future removal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6521 +/- ##
============================================
- Coverage 11.28% 11.28% -0.01%
+ Complexity 6323 6319 -4
============================================
Files 1080 1080
Lines 137528 137531 +3
Branches 21295 21296 +1
============================================
- Hits 15516 15515 -1
Misses 120463 120463
- Partials 1549 1553 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolean isExecutionparameter toprocessPrisonerResolutionCommandto handle execution-specific logic.processPrisonerResolutionCommandmethod in favor of the new one, marking it for future removal.Dev Notes
When the player ordered their PoWs 'freed' via the right-click personnel menu, MekHQ was murdering them instead. Complete with a hit to the player's Reputation.