Improved Image Scaling Utility; Improved Portrait Display in Immersive Dialogs #6549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Dialogs - Replaced `new Dimension` calls with `scaleForGUI` to improve scalability. - Enhanced `scaleImageIcon` to use high-quality rendering with `Graphics2D` for better image scaling. - Adjusted image-related dimensions and padding for improved GUI rendering.
rjhancock
approved these changes
Apr 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6549 +/- ##
============================================
- Coverage 11.28% 11.27% -0.01%
+ Complexity 6321 6313 -8
============================================
Files 1080 1080
Lines 137543 137529 -14
Branches 21300 21295 -5
============================================
- Hits 15517 15504 -13
- Misses 120473 120475 +2
+ Partials 1553 1550 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Dimensioncalls withscaleForGUIto improve scalability.scaleImageIconto use high-quality rendering withGraphics2Dfor better image scaling.Dev Notes
This just makes the image scaler player nicer with our relatively small portraits, allowing us to have larger portraits (such as in Immersive Dialogs) without them appearing pixelated.
While I was there I also went and updated Immersive Dialog to remove some awkward scaling.
Old
New